feat: add initial integration of rattler-build #1876
Conversation
Good question! they will be deleted on final PR version - I'm using them in development process to clearly point what is needed new for rattler-build and will integrate it in the old templates |
|
It would be nice if this were coordinated together with the existing |
|
We should ping @0xbe7a :) |
h-vetinari
changed the title
Hey @xhochy ! |
|
The latest conda-smithy version that bela was working on is here: 0xbe7a@1e818fc |
nichmor
force-pushed
the
feat/use-rattler-build
branch
from
05a96c0
to
0d8161e
Compare
|
hey @isuruf ! Let me know if there is anything else you want me to refactor |
conda_smithy/lint_recipe.py
Outdated
| lint_empty_line_of_the_file(recipe_dir, recipe_fname, lints) | ||
|
|
||
| # 12a: License family must be valid (conda-build checks for that) | ||
| rattler_linter.lint_has_recipe_file(about_section, lints) |
There was a problem hiding this comment.
| rattler_linter.lint_has_recipe_file(about_section, lints) | |
| rattler_linter.lint_has_license_file(about_section, lints) |
conda_smithy/lint_recipe.py
Outdated
| # 15: Check if we are using legacy patterns | ||
| rattler_linter.lint_legacy_patterns(requirements_section) |
There was a problem hiding this comment.
Why is this different from conda-build?
conda_smithy/lint_recipe.py
Outdated
| build_reqs = requirements_section.get("build", None) | ||
| lints.append(rattler_linter.lint_legacy_compilers(build_reqs)) | ||
|
|
||
| # 22: Single space in pinned requirements |
|
As discussed with @isuruf, I've removed the linter from this PR. It will be added in the next one with proper refactoring. |
fixed. rattler-build was cached in the CI on older version |
|
Looks good. Can you add a news entry? |
Added |
|
A piece was missing. Added in #1977. |
High overview of this integration:
conda_build_toolfrom conda-forge now supportrattler-buildtool. If recipe.yaml is present when runningconda-smithy initit will populate the newconda-forge.yamlwith { 'conda_build_tool': 'rattler-build' }MetaDatais created inrattler_build.buildwhich inherit fromconda_build.Metadataand overwrite some necessary methods for itself (get_used_var,get_used_vars). The rational for this is to keep API the same as much as possible.get_package_variantsfunction is copied from conda_build with a few changes for rattler-build ( it's main usage is to support generation of different configs files )rattler_build.loadermodule contains a class that is used as a custom yaml loader which will evaluate rattler-build variants.yaml selectors.rattler_build.utilscontainsfind_recipefunction conda_build with similar API flow, the only necessary change is that VALID_METAS contain recipe.yamlbuild_steps.sh.tmp, run_osx_build.sh.tmpl, run_win_build.bat.tmplcontains addition of rattler-build command which is added in template using jinja if {%- if conda_build_tool != "rattler-build" %}.tests/recipesfolders. ( example:recipes/py_recipe)data/rattler-recipe-schema.json)polarify-feedstock: feat: pre-render with new conda smithy with rattler build support polarify-feedstock#17
Checklist
newsentry