Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure $MINIFORGE_HOME exists during osx build #2142

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Make sure $MINIFORGE_HOME exists during osx build #2142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bfe6822
make sure $MINIFORGE_HOME exists during osx build
hadim Nov 19, 2024
d1df534
add news
hadim Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions conda_smithy/templates/run_osx_build.sh.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ set -xe

MINIFORGE_HOME=${MINIFORGE_HOME:-${HOME}/miniforge3}
MINIFORGE_HOME=${MINIFORGE_HOME%/} # remove trailing slash
mkdir -p ${MINIFORGE_HOME}
Copy link
Member

@jakirkham jakirkham Nov 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work with Miniforge however

The following...

mkdir tst_mf_home_already_present
bash ~/Downloads/Miniforge3-24.9.0-0-MacOSX-arm64.sh -b -p tst_mf_home_already_present

...gives this error...

ERROR: File or directory already exists: 'tst_mf_home_already_present'
If you want to update an existing installation, use the -u option.

Think this should be moved into the pixi block instead or we add -u to the Miniforge command

Edit: Micromamba would likely have the same issue


{%- if conda_install_tool == "micromamba" %}

( startgroup "Provisioning base env with micromamba" ) 2> /dev/null
Expand Down
23 changes: 23 additions & 0 deletions news/pixi_osx.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
**Added:**

* <news item>

**Changed:**

* <news item>

**Deprecated:**

* <news item>

**Removed:**

* <news item>

**Fixed:**

* Make sure $MINIFORGE_HOME folder exists during build.

**Security:**

* <news item>
Loading