-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arch Migrator #46
Arch Migrator #46
Conversation
…nda-forge-pinning 2024.03.21.15.27.47
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
…nda-forge-pinning 2024.07.02.10.47.51
@charlesbluca is there something I can do on the Separately, is it safe to close apache/datafusion-python#701 as completed? This is the last open PR referenced in that issue, but my guess is that the current error is something other than the maturin version. |
…nda-forge-pinning 2024.09.23.09.40.07
The failures are a little foreign to me, just pushed latest
Yup, I think at this point it's safe to close that out as resolved |
@conda-forge-admin , please re-render |
…nda-forge-pinning 2024.10.02.13.37.37
@conda-forge-admin , please re-render |
…nda-forge-pinning 2024.10.02.13.37.37
Seeing the following error on CI:
|
# Taken from clangdev's recipe | ||
# https://github.com/conda-forge/clangdev-feedstock/blob/01fc5e3e0fc690db85151dcb3ff512e6aa876be7/recipe/build.sh#L51-L56 | ||
# disable -fno-plt due to some GCC bug causing linker errors, see | ||
# https://github.com/llvm/llvm-project/issues/51205 | ||
if [[ "$target_platform" == "linux-ppc64le" ]]; then | ||
CFLAGS="$(echo $CFLAGS | sed 's/-fno-plt //g')" | ||
CXXFLAGS="$(echo $CXXFLAGS | sed 's/-fno-plt //g')" | ||
fi | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the aforementioned error ( #46 (comment) ) may be fixed by dropping the -fno-plt
compiler flag. A similar approach is taken in the clangdev
feedstock. Note this also references upstream issue ( llvm/llvm-project#51205 )
@conda-forge-admin , please re-render |
…nda-forge-pinning 2024.10.02.19.54.49
recipe/meta.yaml
Outdated
test: | ||
imports: | ||
- datafusion | ||
commands: | ||
- pip check | ||
- python -c 'from importlib.util import find_spec; assert find_spec("datafusion")' | ||
- python -c 'import datafusion' # [build_platform != target_platform] | ||
requires: | ||
- pip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This testing should work better when cross-compiling. Will allow us to reenable testing there
@conda-forge-admin , please re-render |
…nda-forge-pinning 2024.10.02.19.54.49
@conda-forge-admin , please re-render |
…nda-forge-pinning 2024.10.02.19.54.49
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jakirkham!
Looks like we're still seeing storage pressures during the resulting builds (link) Hopefully shouldn't be a blocker to the ppc64le builds but worth noting if the swapfile changes weren't sufficient to resolve EDIT: Looks like we're all green! https://github.com/conda-forge/datafusion-feedstock/runs/31036235544 |
Thanks Charles! 🙏 Also random question, which browser are you using? |
Was actually going to ask you the same question when I saw the vertical tabs in your screenshot 😂 what are you using? I'm on Microsoft Edge, I've enjoyed the native support for vertical tabs and sidebar apps but could definitely leave the increased Copilot pushing and general Microsoft-isms behind |
Actually the tabs are coming from Azure Pipelines. The browser is Safari Ah ok. Thanks for sharing! 🙏 |
This feedstock is being rebuilt as part of the aarch64/ppc64le migration.
Feel free to merge the PR if CI is all green, but please don't close it
without reaching out the the ARM migrators first at @conda-forge/arm-arch.
If this PR was opened in error or needs to be updated please add the
bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/8386951364, please use this URL for debugging.
Fixes #36