Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arch Migrator #46

Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

@regro-cf-autotick-bot regro-cf-autotick-bot commented Mar 22, 2024

This feedstock is being rebuilt as part of the aarch64/ppc64le migration.

Feel free to merge the PR if CI is all green, but please don't close it
without reaching out the the ARM migrators first at @conda-forge/arm-arch.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/8386951364, please use this URL for debugging.

Fixes #36

@conda-forge-webservices
Copy link
Contributor

conda-forge-webservices bot commented Mar 22, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@Michael-J-Ward
Copy link

@charlesbluca is there something I can do on the datafusion-python side to help with this?

Separately, is it safe to close apache/datafusion-python#701 as completed? This is the last open PR referenced in that issue, but my guess is that the current error is something other than the maturin version.

@charlesbluca
Copy link
Member

@charlesbluca is there something I can do on the datafusion-python side to help with this?

The failures are a little foreign to me, just pushed latest main to this branch so we can have an updated picture of what's not working here

Separately, is it safe to close apache/datafusion-python#701 as completed?

Yup, I think at this point it's safe to close that out as resolved

@jakirkham
Copy link
Member

@conda-forge-admin , please re-render

conda-forge-webservices[bot] and others added 2 commits October 2, 2024 18:31
@jakirkham
Copy link
Member

@conda-forge-admin , please re-render

conda-forge.yml Outdated Show resolved Hide resolved
@jakirkham
Copy link
Member

Seeing the following error on CI:

error: linking with `/home/conda/feedstock_root/build_artifacts/datafusion_1727896622153/_build_env/bin/powerpc64le-conda-linux-gnu-cc` failed: exit status: 1
  |
  = note: LC_ALL="C" PATH="/home/conda/feedstock_root/build_artifacts/datafusion_1727896622153/_build_env/lib/rustlib/x86_64-unknown-linux-gnu/bin:/home/conda/feedstock_root/build_artifacts/datafusion_1727896622153/_build_env/lib/rustlib/x86_64-unknown-linux-gnu/bin:/home/conda/feedstock_root/build_artifacts/datafusion_1727896622153/_build_env/lib/rustlib/x86_64-unknown-linux-gnu/bin:/home/conda/feedstock_root/build_artifacts/datafusion_1727896622153/_build_env/.cargo/bin:/home/conda/feedstock_root/build_artifacts/datafusion_1727896622153/_build_env/bin:/home/conda/feedstock_root/build_artifacts/datafusion_1727896622153/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/bin:/opt/conda/condabin:/home/conda/feedstock_root/build_artifacts/datafusion_1727896622153/_build_env/bin:/home/conda/feedstock_root/build_artifacts/datafusion_1727896622153/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/bin:/opt/conda/bin:/opt/conda/condabin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/home/conda/bin" VSLANG="1033" "/home/conda/feedstock_root/build_artifacts/datafusion_1727896622153/_build_env/bin/powerpc64le-conda-linux-gnu-cc" "-Wl,--version-script=/tmp/rustcOtpgS0/list" "-Wl,--no-undefined-version" "-m64" "/tmp/rustcOtpgS0/symbols.o" "/home/conda/feedstock_root/build_artifacts/datafusion_1727896622153/work/target/powerpc64le-unknown-linux-gnu/release/deps/datafusion_python.datafusion_python.4563b0520d950985-cgu.0.rcgu.o" "-Wl,--as-needed" "-L" "/home/conda/feedstock_root/build_artifacts/datafusion_1727896622153/work/target/powerpc64le-unknown-linux-gnu/release/deps" "-L" "/home/conda/feedstock_root/build_artifacts/datafusion_1727896622153/work/target/release/deps" "-L" "/home/conda/feedstock_root/build_artifacts/datafusion_1727896622153/work/target/powerpc64le-unknown-linux-gnu/release/build/bzip2-sys-ca7d57325964d3fd/out/lib" "-L" "/home/conda/feedstock_root/build_artifacts/datafusion_1727896622153/work/target/powerpc64le-unknown-linux-gnu/release/build/lzma-sys-dd952e7a922abd0d/out" "-L" "/home/conda/feedstock_root/build_artifacts/datafusion_1727896622153/work/target/powerpc64le-unknown-linux-gnu/release/build/zstd-sys-dad6231f79856429/out" "-L" "/home/conda/feedstock_root/build_artifacts/datafusion_1727896622153/work/target/powerpc64le-unknown-linux-gnu/release/build/ring-d9595e46809589f4/out" "-L" "/home/conda/feedstock_root/build_artifacts/datafusion_1727896622153/work/target/powerpc64le-unknown-linux-gnu/release/build/libmimalloc-sys-b76601fd01f468e4/out" "-L" "/home/conda/feedstock_root/build_artifacts/datafusion_1727896622153/_build_env/lib/rustlib/powerpc64le-unknown-linux-gnu/lib" "-Wl,-Bstatic" "/tmp/rustcOtpgS0/libring-10b0972fbbc585ba.rlib" "/tmp/rustcOtpgS0/libzstd_sys-783f7d7f2ba9e443.rlib" "/tmp/rustcOtpgS0/liblzma_sys-87b2372ba5946fb0.rlib" "/tmp/rustcOtpgS0/libbzip2_sys-6e775cde18ea21af.rlib" "/tmp/rustcOtpgS0/liblibmimalloc_sys-7da080d6381c3c3d.rlib" "/home/conda/feedstock_root/build_artifacts/datafusion_1727896622153/_build_env/lib/rustlib/powerpc64le-unknown-linux-gnu/lib/libcompiler_builtins-6bfd94ce73b7199e.rlib" "-Wl,-Bdynamic" "-lgcc_s" "-lutil" "-lrt" "-lpthread" "-lm" "-ldl" "-lc" "-Wl,--eh-frame-hdr" "-Wl,-z,noexecstack" "-L" "/home/conda/feedstock_root/build_artifacts/datafusion_1727896622153/_build_env/lib/rustlib/powerpc64le-unknown-linux-gnu/lib" "-o" "/home/conda/feedstock_root/build_artifacts/datafusion_1727896622153/work/target/powerpc64le-unknown-linux-gnu/release/deps/libdatafusion_python.so" "-Wl,--gc-sections" "-shared" "-Wl,-soname=libdatafusion_python.so" "-Wl,-z,relro,-z,now" "-Wl,-O1" "-Wl,--strip-debug" "-nodefaultlibs" "-s" "-Wl,-rpath-link,/home/conda/feedstock_root/build_artifacts/datafusion_1727896622153/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib" "-Wl,-rpath,/home/conda/feedstock_root/build_artifacts/datafusion_1727896622153/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib"
  = note: /tmp/rustcOtpgS0/liblibmimalloc_sys-7da080d6381c3c3d.rlib(98cfcaec7182b1d8-static.o): in function `_mi_process_init':
          static.c:(.text.startup._mi_process_init+0x58): relocation truncated to fit: R_PPC64_REL24 against symbol `atexit' defined in .text section in /home/conda/feedstock_root/build_artifacts/datafusion_1727896622153/_build_env/bin/../powerpc64le-conda-linux-gnu/sysroot/usr/lib64/libc_nonshared.a(atexit.oS)
          static.c:(.text.startup._mi_process_init+0x6c): relocation truncated to fit: R_PPC64_REL24 against symbol `_mi_options_init' defined in .text._mi_options_init section in /tmp/rustcOtpgS0/liblibmimalloc_sys-7da080d6381c3c3d.rlib(98cfcaec7182b1d8-static.o)
          static.c:(.text.startup._mi_process_init+0x9c): relocation truncated to fit: R_PPC64_REL24 against symbol `_mi_prim_thread_init_auto_done' defined in .text._mi_prim_thread_init_auto_done section in /tmp/rustcOtpgS0/liblibmimalloc_sys-7da080d6381c3c3d.rlib(98cfcaec7182b1d8-static.o)
          static.c:(.text.startup._mi_process_init+0xb4): relocation truncated to fit: R_PPC64_REL24 against symbol `_mi_heap_set_default_direct' defined in .text._mi_heap_set_default_direct section in /tmp/rustcOtpgS0/liblibmimalloc_sys-7da080d6381c3c3d.rlib(98cfcaec7182b1d8-static.o)
          static.c:(.text.startup._mi_process_init+0xc8): relocation truncated to fit: R_PPC64_REL24 against symbol `mi_process_init' defined in .text.mi_process_init section in /tmp/rustcOtpgS0/liblibmimalloc_sys-7da080d6381c3c3d.rlib(98cfcaec7182b1d8-static.o)
          static.c:(.text.startup._mi_process_init+0xe0): relocation truncated to fit: R_PPC64_REL24 against symbol `_mi_random_reinit_if_weak' defined in .text._mi_random_reinit_if_weak section in /tmp/rustcOtpgS0/liblibmimalloc_sys-7da080d6381c3c3d.rlib(98cfcaec7182b1d8-static.o)
          static.c:(.text.startup._mi_process_init+0x10c): relocation truncated to fit: R_PPC64_REL24 against symbol `_mi_thread_id' defined in .text._mi_thread_id section in /tmp/rustcOtpgS0/liblibmimalloc_sys-7da080d6381c3c3d.rlib(98cfcaec7182b1d8-static.o)
          static.c:(.text.startup._mi_process_init+0x130): relocation truncated to fit: R_PPC64_REL24 against symbol `_mi_random_init' defined in .text._mi_random_init section in /tmp/rustcOtpgS0/liblibmimalloc_sys-7da080d6381c3c3d.rlib(98cfcaec7182b1d8-static.o)
          static.c:(.text.startup._mi_process_init+0x148): relocation truncated to fit: R_PPC64_REL24 against symbol `_mi_heap_random_next' defined in .text._mi_heap_random_next section in /tmp/rustcOtpgS0/liblibmimalloc_sys-7da080d6381c3c3d.rlib(98cfcaec7182b1d8-static.o)
          static.c:(.text.startup._mi_process_init+0x168): relocation truncated to fit: R_PPC64_REL24 against symbol `_mi_heap_random_next' defined in .text._mi_heap_random_next section in /tmp/rustcOtpgS0/liblibmimalloc_sys-7da080d6381c3c3d.rlib(98cfcaec7182b1d8-static.o)
          static.c:(.text.startup._mi_process_init+0x188): additional relocation overflows omitted from the output
          collect2: error: ld returned 1 exit status

Comment on lines +19 to +27
# Taken from clangdev's recipe
# https://github.com/conda-forge/clangdev-feedstock/blob/01fc5e3e0fc690db85151dcb3ff512e6aa876be7/recipe/build.sh#L51-L56
# disable -fno-plt due to some GCC bug causing linker errors, see
# https://github.com/llvm/llvm-project/issues/51205
if [[ "$target_platform" == "linux-ppc64le" ]]; then
CFLAGS="$(echo $CFLAGS | sed 's/-fno-plt //g')"
CXXFLAGS="$(echo $CXXFLAGS | sed 's/-fno-plt //g')"
fi

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the aforementioned error ( #46 (comment) ) may be fixed by dropping the -fno-plt compiler flag. A similar approach is taken in the clangdev feedstock. Note this also references upstream issue ( llvm/llvm-project#51205 )

@jakirkham
Copy link
Member

@conda-forge-admin , please re-render

conda-forge-webservices[bot] and others added 2 commits October 2, 2024 21:32
recipe/meta.yaml Outdated
Comment on lines 35 to 41
test:
imports:
- datafusion
commands:
- pip check
- python -c 'from importlib.util import find_spec; assert find_spec("datafusion")'
- python -c 'import datafusion' # [build_platform != target_platform]
requires:
- pip
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This testing should work better when cross-compiling. Will allow us to reenable testing there

conda-forge.yml Outdated Show resolved Hide resolved
@jakirkham
Copy link
Member

@conda-forge-admin , please re-render

conda-forge-webservices[bot] and others added 2 commits October 2, 2024 22:40
@jakirkham
Copy link
Member

@conda-forge-admin , please re-render

recipe/meta.yaml Outdated Show resolved Hide resolved
Copy link
Member

@charlesbluca charlesbluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jakirkham!

@charlesbluca charlesbluca merged commit c83386d into conda-forge:main Oct 3, 2024
26 checks passed
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the bot-pr_arch_h1e510c branch October 3, 2024 14:56
@charlesbluca
Copy link
Member

charlesbluca commented Oct 3, 2024

Looks like we're still seeing storage pressures during the resulting builds (link)

image

Hopefully shouldn't be a blocker to the ppc64le builds but worth noting if the swapfile changes weren't sufficient to resolve

EDIT:

Looks like we're all green!

https://github.com/conda-forge/datafusion-feedstock/runs/31036235544

@jakirkham
Copy link
Member

Thanks Charles! 🙏

Also random question, which browser are you using?

@charlesbluca
Copy link
Member

Was actually going to ask you the same question when I saw the vertical tabs in your screenshot 😂 what are you using?

I'm on Microsoft Edge, I've enjoyed the native support for vertical tabs and sidebar apps but could definitely leave the increased Copilot pushing and general Microsoft-isms behind

@jakirkham
Copy link
Member

Actually the tabs are coming from Azure Pipelines. The browser is Safari

Ah ok. Thanks for sharing! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add linux-ppc64le builds
4 participants