Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre release v2.5.0rc6 #35

Merged
merged 3 commits into from
Mar 10, 2022
Merged

Pre release v2.5.0rc6 #35

merged 3 commits into from
Mar 10, 2022

Conversation

schlunma
Copy link
Contributor

@schlunma schlunma commented Mar 10, 2022 •
edited
Loading

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Closes #30

@schlunma schlunma self-assigned this Mar 10, 2022
@schlunma schlunma requested a review from zklaus as a code owner March 10, 2022 16:48
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@schlunma
Copy link
Contributor Author

@conda-forge-admin, please rerender

zklaus
zklaus approved these changes Mar 10, 2022
View reviewed changes
Copy link

@zklaus zklaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Let's wait for the CI and move along.

valeriupredoi
valeriupredoi approved these changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking sharpe, man 🍺

@schlunma
Copy link
Contributor Author

Thanks guys!!

@schlunma schlunma merged commit 4ffba3a into conda-forge:rc Mar 10, 2022
@schlunma schlunma deleted the v2.5.0rc6 branch March 10, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valeriupredoi valeriupredoi valeriupredoi approved these changes

@zklaus zklaus zklaus approved these changes

@bouweandela bouweandela Awaiting requested review from bouweandela bouweandela is a code owner

@nielsdrost nielsdrost Awaiting requested review from nielsdrost nielsdrost is a code owner

Assignees

@schlunma schlunma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@schlunma @conda-forge-linter @zklaus @valeriupredoi