Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to 1.7.1 #46

Merged
merged 19 commits into from
Oct 13, 2021
Merged

Bump to 1.7.1 #46

merged 19 commits into from
Oct 13, 2021

Conversation

h-vetinari
Copy link
Member

Not sure why the bot didn't pick this one up yet (and whether I can get further with the build adaptations than in #35)...

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari h-vetinari force-pushed the bump branch 2 times, most recently from 030030f to cedaffa Compare June 4, 2021 15:03
@h-vetinari
Copy link
Member Author

OK, first builds passing again... Now just failing on a (flaky?) test...
FAILED tests/test_residual_quantizer.py::TestAdditiveQuantizerWithLUT::test_RCQ_knn

=================================== FAILURES ===================================
__________________ TestAdditiveQuantizerWithLUT.test_RCQ_knn ___________________

self = <test_residual_quantizer.TestAdditiveQuantizerWithLUT testMethod=test_RCQ_knn>

    def test_RCQ_knn(self):
        ds = datasets.SyntheticDataset(32, 1000, 0, 123)
        xt = ds.get_train()
        xq = ds.get_queries()
    
        # RQ 3+4+5 = 12 bits = 4096 centroids
        rcq = faiss.index_factory(ds.d, "RCQ1x3_1x4_1x5")
        rcq.train(xt)
    
        aq = rcq.rq
    
        cents = rcq.reconstruct_n(0, rcq.ntotal)
    
        sp = faiss.swig_ptr
    
        # test norms computation
    
        norms_ref = (cents ** 2).sum(1)
        norms = np.zeros(1 << aq.tot_bits, dtype="float32")
        aq.compute_centroid_norms(sp(norms))
E        x: array([ 7.76706, 15.41243,  2.32282, ..., 36.52338, 25.93759, 45.54408],
E             dtype=float32)
E        y: array([ 7.76706, 15.41243,  2.32282, ..., 36.52338, 25.93759, 45.54408],
E             dtype=float32)

@h-vetinari
Copy link
Member Author

h-vetinari commented Jun 5, 2021

@conda-forge/vc
It seems that the new compilers in the win-2019 image somehow regressed? The master branch built the same recipe fine essentially, but not this yields weird compilation errors (not related to the version bump, the same errors appear in #45).

I tried downgrading to vs 2017, which worked (mostly - this recipe is just prone to timeouts for win+cuda), see second-to-last CI run...

@h-vetinari
Copy link
Member Author

Though it could also be something with nvcc, because cuda10.2 seems to build fine on vs2019, whereas cuda11.x fails.

CC @conda-forge/nvcc

facebook-github-bot pushed a commit to facebookresearch/faiss that referenced this pull request Jun 7, 2021
Summary:
Some small fixes from conda-forge/faiss-split-feedstock#46; some missing (and unsorted) headers like in #1666, and a missing `<algorithm>` include like in  #1895

Pull Request resolved: #1933

Reviewed By: mdouze

Differential Revision: D28931009

Pulled By: beauby

fbshipit-source-id: c8a9e52a9237dc0bb87664441a76a5db47cc821a
@h-vetinari
Copy link
Member Author

@conda-forge-admin, please rerender

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants