Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add aarch64 and ppc64le #2

Merged
merged 8 commits into from
Feb 23, 2024
Merged

build: add aarch64 and ppc64le #2

merged 8 commits into from
Feb 23, 2024

Conversation

lgray
Copy link
Contributor

@lgray lgray commented Feb 22, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@lgray
Copy link
Contributor Author

lgray commented Feb 22, 2024

@conda-forge-admin, please rerender

@lgray lgray added the automerge Merge the PR when CI passes label Feb 22, 2024
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • travis: failed
  • azure: passed

Thus the PR was not passing and not merged.

@lgray
Copy link
Contributor Author

lgray commented Feb 23, 2024

@matthewfeickert it seems to only be failing for some combinations, please have a look!

@matthewfeickert
Copy link
Member

Oh man. Travis CI error logs. A blast from the past that's giving me some mental and emotional damage. 😬

The build matrix failures are confusing too as they seem to only be CPython version based. :?

image

I'll have to dig through and also learn what

"if [[ ${PLATFORM} =~ .*linux.* ]]; then CONDA_FORGE_DOCKER_RUN_ARGS="--network=host --security-opt=seccomp=unconfined" ./.scripts/run_docker_build.sh; fi" exited with 137.

is all about.

@matthewfeickert matthewfeickert mentioned this pull request Feb 23, 2024
3 tasks
@lgray
Copy link
Contributor Author

lgray commented Feb 23, 2024

@conda-forge-admin, please rerender

@github-actions github-actions bot removed the automerge Merge the PR when CI passes label Feb 23, 2024
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@lgray
Copy link
Contributor Author

lgray commented Feb 23, 2024

@matthewfeickert may have found an easier way through - just use azure instead ^_^

@lgray lgray added the automerge Merge the PR when CI passes label Feb 23, 2024
@lgray
Copy link
Contributor Author

lgray commented Feb 23, 2024

While this might take a while since it's emulated, I imagine it is far better than trying to setup this build system for cross compilation.

@matthewfeickert
Copy link
Member

While this might take a while since it's emulated, I imagine it is far better than trying to setup this build system for cross compilation.

@lgray yeah if we can avoid using Travis CI I would be very happy. I assume there's no way to use Cirrus CI as a provider? If not, as long as this stays under 2 hours of build time I think that's okay (we can also turn things off as needed if we need to debug in a PR).

conda-forge.yml Outdated
Comment on lines 7 to 9
provider:
linux_aarch64: azure
linux_ppc64le: azure
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lgray can you link to the docs that you read that cover providers? I'm trying to assemeble some conda-forge bookmarks for myself for the future. 😬

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lgray
Copy link
Contributor Author

lgray commented Feb 23, 2024

Huh, the builds in azure keep getting to:

libtool: compile:  $BUILD_PREFIX/bin/aarch64-conda-linux-gnu-c++ -DHAVE_CONFIG_H -I. -I../include/fastjet -DNDEBUG -D_FORTIFY_SOURCE=2 -O2 -isystem $PREFIX/include -g -Woverloaded-virtual -frounding-math -I./../include -fvisibility-inlines-hidden -fmessage-length=0 -ftree-vectorize -fPIC -fstack-protector-strong -fno-plt -O3 -pipe -isystem $PREFIX/include -fdebug-prefix-map=$SRC_DIR=/usr/local/src/conda/fastjet-3.4.0.6 -fdebug-prefix-map=$PREFIX=/usr/local/src/conda-prefix -O3 -Bstatic -Bdynamic -std=c++17 -MT libfastjet_la-RangeDefinition.lo -MD -MP -MF .deps/libfastjet_la-RangeDefinition.Tpo -c RangeDefinition.cc -o libfastjet_la-RangeDefinition.o >/dev/null 2>&1

and then completing wreck the node they're on for some reason.

it is consistently that file on every single build.

@lgray
Copy link
Contributor Author

lgray commented Feb 23, 2024

@conda-forge-admin, please rerender

Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@github-actions github-actions bot removed the automerge Merge the PR when CI passes label Feb 23, 2024
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the latest rerendering GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or try re-rendering locally.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/fastjet-feedstock/actions/runs/8024264721.

@lgray
Copy link
Contributor Author

lgray commented Feb 23, 2024

@conda-forge-admin, please rerender

@matthewfeickert
Copy link
Member

matthewfeickert commented Feb 23, 2024

Could also try using Circle CI: https://circleci.com/docs/using-arm/

edit: You already did that. Never mind.

But it is strange that it keeps failing at that one spot.

@lgray
Copy link
Contributor Author

lgray commented Feb 23, 2024

@conda-forge-admin, please update circle.

@matthewfeickert
Copy link
Member

@lgray have you actually succeeded in building the fastjet wheel on aarch_64 Linux machine before? If not, I can try to build on an RPi and see where things break down.

@lgray
Copy link
Contributor Author

lgray commented Feb 23, 2024

Oh it works on cirrus no problem and we use it to build wheels quickly. The builds were completing on travis in some cases just fine as well. It really seems to be a worker memory issue in some versions of python.

ppc64le was also succeeding for certain python versions, just not all of them.

@lgray
Copy link
Contributor Author

lgray commented Feb 23, 2024

@conda-forge-admin, please add circle

@matthewfeickert
Copy link
Member

Oh it works on cirrus no problem and we use it to build wheels quickly

Oh right. I forgot that I added the PR for that. scikit-hep/fastjet#168 🤪 Time to step away from the keyboard and make a coffee.

Thanks for steering this and getting these builds going in the right direction.

@lgray
Copy link
Contributor Author

lgray commented Feb 23, 2024

@chrisburr does conda-forge no longer actually use circle-ci or do I need to go through some extra hoops I don't know about?

@lgray
Copy link
Contributor Author

lgray commented Feb 23, 2024

I have a feeling I need to first merge this and then it'll work.

@lgray
Copy link
Contributor Author

lgray commented Feb 23, 2024

I'm gonna yolo this one for now. It won't screw up the x86 builds that are already there.

@lgray lgray merged commit a720413 into conda-forge:main Feb 23, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants