-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use conda-forge cross-compilation to improve the build process #6
feat: Use conda-forge cross-compilation to improve the build process #6
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
@conda-forge/help-python trying to add the requested build:
- {{ compiler('c') }}
- {{ compiler('cxx') }}
+ - {{ stdlib("c") }}
- cross-python_{{ target_platform }} # [build_platform != target_platform]
- python # [build_platform != target_platform]
- autoconf results in the following "nothing provides requested c_linux-64" traceback :
Do you have any advice here? |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
Ah okay, this required a rerender to work. In that case, I want to keep things atomic, so I'm going to put this back into draft, and open up a seperate PR (PR #7) that is just doing the stdlib c bit. |
* Use the cross-compilation selector, '[build_platform != target_platform]', to simplify the build process by just doing a pip install. - c.f. https://conda-forge.org/docs/maintainer/knowledge_base/#details-about-cross-compiled-python-packages * Add the cross-python and python build dependency. * Remove the python-build host dependency. * Bump the build number.
301f98c
to
fc5db17
Compare
@conda-forge-admin, please lint |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/fastjet-feedstock/actions/runs/9037803728. |
@conda-forge/fastjet This is actually ready for review now. |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)