Fix packaged version. #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
|
I wonder how it go to be like this... |
|
Seems like the fn vs. fn_suffix split goes back a ways. And presumably the
retro-bot doesn't handle it well.
…On Thu, Jan 3, 2019 at 11:32 AM Martin Durant ***@***.***> wrote:
I wonder how it go to be like this...
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#21 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQHIu4thtF0RDXZqmf4mC_HfCKhp2Tgks5u_j61gaJpZM4ZofJZ>
.
|
|
The circleci failures may be due to a dockerhub outage. |
|
Agreed. Better wait a little while. |
|
By the way, RTD build also failed on the last merge https://readthedocs.org/projects/fastparquet/builds/8294621/ |
|
Going to merge. I don't have a guess for the RTD build... A bit of googling suggests that can happen when you try to get the git hash for an empty repo, but that doesn't make sense here. |
|
Reran RTD, and it passed, so never mind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixup for #20
cc @martindurant.
We'll need to remember to reset the build number to 0 on the next build.