Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap libgomp with llvm-openmp #11

Merged
merged 5 commits into from
Aug 12, 2019
Merged

Swap libgomp with llvm-openmp #11

merged 5 commits into from
Aug 12, 2019

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Aug 12, 2019

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

See conda-forge/conda-forge.github.io#831

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • The outputs section contained an unexpected subsection name. run_exports is not a valid subsection name.

@beckermr
Copy link
Member

This needs a build number bump.

@beckermr
Copy link
Member

@conda-forge-admin, please rerender

@beckermr
Copy link
Member

I am confused as to how this swaps the libraries under the hood. The recipes still package libgomp and they don't make any symlinks to help downstream packages out during compilation.

@isuruf
Copy link
Member Author

isuruf commented Aug 12, 2019

Forgot to commit changes to build.sh. 😄

@beckermr
Copy link
Member

@isuruf
Copy link
Member Author

isuruf commented Aug 12, 2019

Yes, that's fine for now. I don't think there are any packages in conda-forge, that links statically

Copy link
Member

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I'll wait for you to merge since it was not clear if we should actually merge this (yet) given the other thread.

@isuruf isuruf merged commit 1dbd4d3 into conda-forge:master Aug 12, 2019
@isuruf
Copy link
Member Author

isuruf commented Aug 12, 2019

Only camb will be affected

@isuruf isuruf deleted the openmp branch August 12, 2019 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants