Add SZip support using libaec #179
Conversation
adamcpovey
requested review from
SylvainCorlay,
astrofrog-conda-forge,
davidbrochart,
gillins,
groutr,
hmaarrfk,
jakirkham,
marcelotrevisani,
ocefpaf,
scopatz and
varlackc
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Very nice. Only osx cross compilation failing. |
| @@ -85,6 +85,7 @@ fi | |||
| --host="${HOST}" \ | |||
| --build="${BUILD}" \ | |||
| --with-zlib="${PREFIX}" \ | |||
| --with-szlib="${PREFIX}" \ | |||
There was a problem hiding this comment.
You might need to export something to help hdf5 identify the configuration for cross compilation
There was a problem hiding this comment.
Took me a bit to work out what you meant, but I eventually tracked down which bit of the configure was failing. I can't check it here so let's push and see what happens
| ${hdf5_disable_tests} | ||
| ${hdf5_disable_tests} \ | ||
| || (cat config.log; false) |
There was a problem hiding this comment.
This should help us see any details related to configuration errors (atm ones on macOS, but is generally useful outside of this need)
|
Added a note in the OP for those interested in knowing how Hope that is ok 🙂 |
|
@conda-forge-admin, please re-render |
…nda-forge-pinning 2022.08.04.07.32.40
- configure can't run AC_LANG_PROGRAM to check if SZip encodes when cross-compiling so we override that with an export - Used incorrect library extension for Windows
Co-authored-by: Mark Harfouche <mark.harfouche@gmail.com>
|
Conda is still not detecting libaec being linked to in the windows builds. We need to investigate a little more. |
It just occurred to me to check that repo. Doesn't this line mean they're skipping Windows: https://github.com/conda-forge/libaec-feedstock/blob/caeab9823b3bf204a9d443f966cf8e0ff56862c8/recipe/meta.yaml#L20 |
|
No. That is only for windows and visual studio 2008 |
|
Folks, what is the status of this PR? I was going to tackle this today but found this one open. |
|
I believe this is still true.
|
Thanks Mark! Would folks be OK with a not win version of this? We can open an issue an work on it later. |
|
beyond licensing concerns, which seem to be addressed. I'm not super concerned. |
|
Yeah we can always raise an issue about Windows support for libaec Idk if there is a good test we could add to exercise libaec support. That might be worth doing Having this improvement (even in a limited form) would be good |
+1
@adamcpovey is there something we can add as a test? Maybe a small compress file and try to read it? I'm keen to merge this soon. Should we remove the changes on Windows and raise the issue? Or leave them there to help the next person who picks this up? |
|
TBH the test isn't a blocker, but it would just help make sure things continue to work Perhaps we could repurpose issue ( #120 ) and rescope to Windows only? Though a new issue would work (if preferred) Would lean towards dropping the Windows changes just to avoid giving the impression this is working. Though no strong feelings if others have preferences Generally +1 on moving to getting this in ASAP |
The computer I do all of this work on is currently unresponsive. Once it works again, I'll try to put together a snippet of code that makes a small compressed file then opens it. |
|
@ocefpaf did you want to merge this? |
I do! Sorry I forgot about this one. We are missing Windows support right? |
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)Closes #120
I've only tested the Linux build as that's the machine I have access to.
(Edit by @jakirkham): More context on SZip support in
libaeccan be found in this README.