Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hendrics v8.0.5 #19

Merged
merged 6 commits into from
Oct 22, 2024

Conversation

regro-cf-autotick-bot
Copy link
Contributor

@regro-cf-autotick-bot regro-cf-autotick-bot commented Oct 19, 2024

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/11413544609 - please use this URL for debugging.

@regro-cf-autotick-bot
Copy link
Contributor Author

Hi! This feedstock was not able to be rerendered after the version update changes. I
have pushed the version update changes anyways and am trying to rerender again with this
comment. Hopefully you all can fix this!

@conda-forge-admin rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.
I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • No valid build backend found for Python recipe for package hendrics using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.

conda-forge-webservices[bot] and others added 2 commits October 19, 2024 02:14
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@matteobachetti
Copy link
Contributor

@conda-forge/core I have no idea what is going on 😅 . I added setuptools to the host section as suggested, but Azure pipelines still says that stingray requires setuptools

@synapticarbors
Copy link
Member

If I had to guess, pip check is complaining because stingray (probably incorrectly) specifies setuptools and setuptools_scm as dependencies, which are run-time dependencies:
https://github.com/StingraySoftware/stingray/blob/main/pyproject.toml#L37-L38

rather than setup_requires or in the build-system.

@beckermr
Copy link
Member

Feel free to remove pip check.

@xhochy
Copy link
Member

xhochy commented Oct 20, 2024

Please don't do this but rather patch it. Otherwise all downstream packages cannot use pip check anymore.

@hmaarrfk
Copy link

They will have to do in the feedstock of the offending package.

@matteobachetti
Copy link
Contributor

Ok, I'll try to fix the stingray feedstock then

@hmaarrfk
Copy link

I see that you are invovled with the stingray software upstream.

I would see if you can remove setuptools as a runtime dependency alltogether, a quick search shows it might not be necessary.
https://github.com/search?q=repo%3AStingraySoftware%2Fstingray+setuptools&type=code

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.
I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • No valid build backend found for Python recipe for package hendrics using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@matteobachetti matteobachetti merged commit ea0ac8c into conda-forge:main Oct 22, 2024
4 checks passed
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 8.0.5_h5120c5 branch October 22, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants