-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a fortran compiler as a dependency #46
Conversation
The build script ends up pip installing a number of packages such as scipy. Typically these packages will be installed via pre-compiled wheels, but if a wheel is not available they will be compiled from source. This process is opaque to conda so it doesn't help with installing the dependencies, so we have to list them explicitly. In this case, building scipy requires a fortran compiler. This is particularly important for building for Pyston because there are currently no pre-compiled wheels available in pypi.
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
@conda-forge-admin, please re-render (needed for the compiler addition) |
…nda-forge-pinning 2022.04.01.23.36.23
This makes no sense to me. scipy is pre-compiled as a conda |
This is bizarre. Looks like @kmod was right that a ton of wheels were installed from PyPI: |
maybe the correct fix is to add scikit-build to the |
Yeah - I also see a ton of wheels being pulled from pypi and that shouldn't be required. Like @leofang pointed out, I might have configured this wrong. I'm wondering if I need to update this line here: implicit-feedstock/recipe/meta.yaml Line 42 in 92182a0
This is using pip to build, and I'm wondering if I should update to not use pip here and maybe change to something like
and then make sure that the build dependencies like scikit-build/cmake etc are all listed in the conda host requirements. Though, I'm really not a conda expert and would appreciate suggestions from everyone here |
Ben, if you have some time next week, maybe we can take a look at this together 🙂 |
@conda-forge-admin, rerender |
…nda-forge-pinning 2022.04.02.04.11.01
That would be great! I also have some questions about the CUDA builds that maybe you could point me in the right direction on - |
This is probably conda/conda-build#3993 |
The build script ends up pip installing a number of packages
such as scipy. Typically these packages will be installed via
pre-compiled wheels, but if a wheel is not available they
will be compiled from source. This process is opaque to conda
so it doesn't help with installing the dependencies, so we have
to list them explicitly. In this case, building scipy requires
a fortran compiler.
This is particularly important for building for Pyston because
there are currently no pre-compiled wheels available in pypi.