Changes to support onemkl 2024.0 packages #61

maria-Petrova · 2023-12-05T13:55:49Z

Checklist

Used a personal fork of the feedstock to propose changes
Bumped the build number (if the version is unchanged)
Reset the build number to 0 (if the version changed)
Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
Ensured the license file is being packaged.

conda-forge-webservices · 2023-12-05T13:56:00Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
pin_compatible should be used instead of pin_subpackage for dpcpp-cpp-rt because it is not a known output of this recipe: ['mkl', 'mkl-include', 'onemkl-sycl-blas', 'onemkl-sycl-datafitting', 'onemkl-sycl-dft', 'onemkl-sycl-lapack', 'onemkl-sycl-rng', 'onemkl-sycl-sparse', 'onemkl-sycl-stats', 'onemkl-sycl-vm', 'mkl-devel', 'dal', 'dal-include', 'dal-static', 'dal-devel', 'impi_rt', 'impi-devel', 'intel_repack'].
pin_compatible should be used instead of pin_subpackage for intel-opencl-rt because it is not a known output of this recipe: ['mkl', 'mkl-include', 'onemkl-sycl-blas', 'onemkl-sycl-datafitting', 'onemkl-sycl-dft', 'onemkl-sycl-lapack', 'onemkl-sycl-rng', 'onemkl-sycl-sparse', 'onemkl-sycl-stats', 'onemkl-sycl-vm', 'mkl-devel', 'dal', 'dal-include', 'dal-static', 'dal-devel', 'impi_rt', 'impi-devel', 'intel_repack'].
pin_compatible should be used instead of pin_subpackage for dpcpp-cpp-rt because it is not a known output of this recipe: ['mkl', 'mkl-include', 'onemkl-sycl-blas', 'onemkl-sycl-datafitting', 'onemkl-sycl-dft', 'onemkl-sycl-lapack', 'onemkl-sycl-rng', 'onemkl-sycl-sparse', 'onemkl-sycl-stats', 'onemkl-sycl-vm', 'mkl-devel', 'dal', 'dal-include', 'dal-static', 'dal-devel', 'impi_rt', 'impi-devel', 'intel_repack'].
pin_compatible should be used instead of pin_subpackage for intel-opencl-rt because it is not a known output of this recipe: ['mkl', 'mkl-include', 'onemkl-sycl-blas', 'onemkl-sycl-datafitting', 'onemkl-sycl-dft', 'onemkl-sycl-lapack', 'onemkl-sycl-rng', 'onemkl-sycl-sparse', 'onemkl-sycl-stats', 'onemkl-sycl-vm', 'mkl-devel', 'dal', 'dal-include', 'dal-static', 'dal-devel', 'impi_rt', 'impi-devel', 'intel_repack'].
pin_compatible should be used instead of pin_subpackage for dpcpp-cpp-rt because it is not a known output of this recipe: ['mkl', 'mkl-include', 'onemkl-sycl-blas', 'onemkl-sycl-datafitting', 'onemkl-sycl-dft', 'onemkl-sycl-lapack', 'onemkl-sycl-rng', 'onemkl-sycl-sparse', 'onemkl-sycl-stats', 'onemkl-sycl-vm', 'mkl-devel', 'dal', 'dal-include', 'dal-static', 'dal-devel', 'impi_rt', 'impi-devel', 'intel_repack'].
pin_compatible should be used instead of pin_subpackage for intel-opencl-rt because it is not a known output of this recipe: ['mkl', 'mkl-include', 'onemkl-sycl-blas', 'onemkl-sycl-datafitting', 'onemkl-sycl-dft', 'onemkl-sycl-lapack', 'onemkl-sycl-rng', 'onemkl-sycl-sparse', 'onemkl-sycl-stats', 'onemkl-sycl-vm', 'mkl-devel', 'dal', 'dal-include', 'dal-static', 'dal-devel', 'impi_rt', 'impi-devel', 'intel_repack'].
pin_compatible should be used instead of pin_subpackage for dpcpp-cpp-rt because it is not a known output of this recipe: ['mkl', 'mkl-include', 'onemkl-sycl-blas', 'onemkl-sycl-datafitting', 'onemkl-sycl-dft', 'onemkl-sycl-lapack', 'onemkl-sycl-rng', 'onemkl-sycl-sparse', 'onemkl-sycl-stats', 'onemkl-sycl-vm', 'mkl-devel', 'dal', 'dal-include', 'dal-static', 'dal-devel', 'impi_rt', 'impi-devel', 'intel_repack'].
pin_compatible should be used instead of pin_subpackage for intel-opencl-rt because it is not a known output of this recipe: ['mkl', 'mkl-include', 'onemkl-sycl-blas', 'onemkl-sycl-datafitting', 'onemkl-sycl-dft', 'onemkl-sycl-lapack', 'onemkl-sycl-rng', 'onemkl-sycl-sparse', 'onemkl-sycl-stats', 'onemkl-sycl-vm', 'mkl-devel', 'dal', 'dal-include', 'dal-static', 'dal-devel', 'impi_rt', 'impi-devel', 'intel_repack'].
pin_compatible should be used instead of pin_subpackage for dpcpp-cpp-rt because it is not a known output of this recipe: ['mkl', 'mkl-include', 'onemkl-sycl-blas', 'onemkl-sycl-datafitting', 'onemkl-sycl-dft', 'onemkl-sycl-lapack', 'onemkl-sycl-rng', 'onemkl-sycl-sparse', 'onemkl-sycl-stats', 'onemkl-sycl-vm', 'mkl-devel', 'dal', 'dal-include', 'dal-static', 'dal-devel', 'impi_rt', 'impi-devel', 'intel_repack'].
pin_compatible should be used instead of pin_subpackage for intel-opencl-rt because it is not a known output of this recipe: ['mkl', 'mkl-include', 'onemkl-sycl-blas', 'onemkl-sycl-datafitting', 'onemkl-sycl-dft', 'onemkl-sycl-lapack', 'onemkl-sycl-rng', 'onemkl-sycl-sparse', 'onemkl-sycl-stats', 'onemkl-sycl-vm', 'mkl-devel', 'dal', 'dal-include', 'dal-static', 'dal-devel', 'impi_rt', 'impi-devel', 'intel_repack'].
pin_compatible should be used instead of pin_subpackage for dpcpp-cpp-rt because it is not a known output of this recipe: ['mkl', 'mkl-include', 'onemkl-sycl-blas', 'onemkl-sycl-datafitting', 'onemkl-sycl-dft', 'onemkl-sycl-lapack', 'onemkl-sycl-rng', 'onemkl-sycl-sparse', 'onemkl-sycl-stats', 'onemkl-sycl-vm', 'mkl-devel', 'dal', 'dal-include', 'dal-static', 'dal-devel', 'impi_rt', 'impi-devel', 'intel_repack'].
pin_compatible should be used instead of pin_subpackage for intel-opencl-rt because it is not a known output of this recipe: ['mkl', 'mkl-include', 'onemkl-sycl-blas', 'onemkl-sycl-datafitting', 'onemkl-sycl-dft', 'onemkl-sycl-lapack', 'onemkl-sycl-rng', 'onemkl-sycl-sparse', 'onemkl-sycl-stats', 'onemkl-sycl-vm', 'mkl-devel', 'dal', 'dal-include', 'dal-static', 'dal-devel', 'impi_rt', 'impi-devel', 'intel_repack'].
pin_compatible should be used instead of pin_subpackage for dpcpp-cpp-rt because it is not a known output of this recipe: ['mkl', 'mkl-include', 'onemkl-sycl-blas', 'onemkl-sycl-datafitting', 'onemkl-sycl-dft', 'onemkl-sycl-lapack', 'onemkl-sycl-rng', 'onemkl-sycl-sparse', 'onemkl-sycl-stats', 'onemkl-sycl-vm', 'mkl-devel', 'dal', 'dal-include', 'dal-static', 'dal-devel', 'impi_rt', 'impi-devel', 'intel_repack'].
pin_compatible should be used instead of pin_subpackage for intel-opencl-rt because it is not a known output of this recipe: ['mkl', 'mkl-include', 'onemkl-sycl-blas', 'onemkl-sycl-datafitting', 'onemkl-sycl-dft', 'onemkl-sycl-lapack', 'onemkl-sycl-rng', 'onemkl-sycl-sparse', 'onemkl-sycl-stats', 'onemkl-sycl-vm', 'mkl-devel', 'dal', 'dal-include', 'dal-static', 'dal-devel', 'impi_rt', 'impi-devel', 'intel_repack'].
pin_compatible should be used instead of pin_subpackage for dpcpp-cpp-rt because it is not a known output of this recipe: ['mkl', 'mkl-include', 'onemkl-sycl-blas', 'onemkl-sycl-datafitting', 'onemkl-sycl-dft', 'onemkl-sycl-lapack', 'onemkl-sycl-rng', 'onemkl-sycl-sparse', 'onemkl-sycl-stats', 'onemkl-sycl-vm', 'mkl-devel', 'dal', 'dal-include', 'dal-static', 'dal-devel', 'impi_rt', 'impi-devel', 'intel_repack'].
pin_compatible should be used instead of pin_subpackage for intel-opencl-rt because it is not a known output of this recipe: ['mkl', 'mkl-include', 'onemkl-sycl-blas', 'onemkl-sycl-datafitting', 'onemkl-sycl-dft', 'onemkl-sycl-lapack', 'onemkl-sycl-rng', 'onemkl-sycl-sparse', 'onemkl-sycl-stats', 'onemkl-sycl-vm', 'mkl-devel', 'dal', 'dal-include', 'dal-static', 'dal-devel', 'impi_rt', 'impi-devel', 'intel_repack'].

napetrov · 2023-12-05T14:04:35Z

@conda-forge-admin, please rerender

recipe/meta.yaml

…nda-forge-pinning 2023.12.05.11.44.25

recipe/meta.yaml

conda-forge-webservices · 2023-12-05T15:14:28Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).

napetrov · 2023-12-05T15:17:24Z

@conda-forge-admin, please rerender

github-actions · 2023-12-05T15:19:29Z

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/intel_repack-feedstock/actions/runs/7102779228.

recipe/meta.yaml

napetrov · 2023-12-06T15:38:37Z

recipe/meta.yaml

 outputs:
+{% if not osx %}


my guess is that this have to be handled by line 98 ?

skip: True # [not x86 and not (linux64 or win)]

skip in global build section will cause all outputs to cancel.

oleksandr-pavlyk · 2023-12-06T16:33:22Z

recipe/meta.yaml

+    test:
+      commands:
+          - ls -A $PREFIX/lib/*  # [unix]
+          - test -f $PREFIX/lib/libmkl_sycl_data_fitting.so  # [unix]


Since we already use SONAME version in the filename for Windows, perhaps we should be changing for libmkl_sycl_data_filling.so.4 here too

oleksandr-pavlyk · 2023-12-06T18:35:19Z

Somehow the recipe ran on OSX and produced an artifact:

INFO :: The inputs making up the hashes for the built packages are as follows:
{
  "intel_repack-2024.0.1-hbb52d48_": {
    "recipe": {
      "channel_targets": "conda-forge main",
      "llvm_openmp": "16",
      "mkl": "2023",
      "target_platform": "osx-64"
    }
  }
}

This should not be happening at all for MKL 2024, right?

napetrov · 2023-12-06T20:50:39Z

Somehow the recipe ran on OSX and produced an artifact:

INFO :: The inputs making up the hashes for the built packages are as follows:
{
  "intel_repack-2024.0.1-hbb52d48_": {
    "recipe": {
      "channel_targets": "conda-forge main",
      "llvm_openmp": "16",
      "mkl": "2023",
      "target_platform": "osx-64"
    }
  }
}

This should not be happening at all for MKL 2024, right?

i think this is normal as this in intel_repack feedstock itself and not a one of package outputs

napetrov · 2023-12-06T20:51:09Z

@conda-forge-admin, please rerender

…nda-forge-pinning 2023.12.05.22.51.14

napetrov · 2023-12-06T21:13:44Z

Somehow the recipe ran on OSX and produced an artifact:
INFO :: The inputs making up the hashes for the built packages are as follows:
{
  "intel_repack-2024.0.1-hbb52d48_": {
    "recipe": {
      "channel_targets": "conda-forge main",
      "llvm_openmp": "16",
      "mkl": "2023",
      "target_platform": "osx-64"
    }
  }
}
This should not be happening at all for MKL 2024, right?
i think this is normal as this in intel_repack feedstock itself and not a one of package outputs

looks that it's actually not as this intel_repack output was added - 7102af3 , which shouldn't happen

maria-Petrova · 2023-12-07T15:32:38Z

@conda-forge-admin, please rerender

…nda-forge-pinning 2023.12.07.14.39.07

maria-Petrova · 2023-12-07T16:03:49Z

@conda-forge-admin, please rerender

…nda-forge-pinning 2023.12.07.15.47.22

h-vetinari · 2024-01-11T05:00:56Z

So this PR intentionally removed support for osx-64. I'm guessing that's permanent and not coming back?

napetrov · 2024-01-11T07:45:16Z

So this PR intentionally removed support for osx-64. I'm guessing that's permanent and not coming back?

Correct. There is no MacOS packages created by intel starting from 2024.0 release

Initial changes to support onemkl 2024.0 packages

88a545f

maria-Petrova requested review from Alexsandruss, beckermr, isuruf, napetrov and oleksandr-pavlyk as code owners December 5, 2023 13:55

napetrov reviewed Dec 5, 2023

View reviewed changes

recipe/meta.yaml Outdated Show resolved Hide resolved

MNT: Re-rendered with conda-build 3.28.0, conda-smithy 3.30.1, and co…

f6a8f61

…nda-forge-pinning 2023.12.05.11.44.25

napetrov reviewed Dec 5, 2023

View reviewed changes

recipe/meta.yaml Outdated Show resolved Hide resolved

Address comments

bdcb9f8

maria-Petrova requested a review from napetrov December 5, 2023 14:33

napetrov reviewed Dec 5, 2023

View reviewed changes

recipe/meta.yaml Outdated Show resolved Hide resolved

Address comments

202bc30

napetrov reviewed Dec 5, 2023

View reviewed changes

recipe/meta.yaml Show resolved Hide resolved

maria-Petrova force-pushed the upd/2024.0.1-onedal branch from bad2ce1 to d26f8ff Compare December 5, 2023 16:50

Add condition for macOS

dcbb735

maria-Petrova force-pushed the upd/2024.0.1-onedal branch from 317ef73 to dcbb735 Compare December 5, 2023 17:31

maria-Petrova added 4 commits December 5, 2023 09:43

Add condition for macOS

8ad3f61

Fix if condition

fdd94a8

Fix if condition

dae04dd

Fix mkl libs naming

256905a

maria-Petrova requested a review from napetrov December 6, 2023 15:35

napetrov reviewed Dec 6, 2023

View reviewed changes

maria-Petrova added 2 commits December 6, 2023 07:58

Verify skip option

f051f41

osx workaround

71f01f7

oleksandr-pavlyk reviewed Dec 6, 2023

View reviewed changes

Address versioning comment

8ccc3ba

maria-Petrova requested review from napetrov and oleksandr-pavlyk December 6, 2023 16:44

MNT: Re-rendered with conda-build 3.27.0, conda-smithy 3.30.1, and co…

7102af3

…nda-forge-pinning 2023.12.05.22.51.14

Disable osx build

3890eed

conda-forge-webservices[bot] and others added 4 commits December 7, 2023 15:34

MNT: Re-rendered with conda-build 3.27.0, conda-smithy 3.30.1, and co…

12d096f

…nda-forge-pinning 2023.12.07.14.39.07

Restore meta.yaml

a35c7ea

Attempt to disable osx

0adbf19

Attempt to disable osx

c28ca34

MNT: Re-rendered with conda-build 3.28.1, conda-smithy 3.30.1, and co…

fba8f42

…nda-forge-pinning 2023.12.07.15.47.22

napetrov approved these changes Dec 7, 2023

View reviewed changes

oleksandr-pavlyk approved these changes Dec 7, 2023

View reviewed changes

napetrov merged commit e1d0aaf into conda-forge:main Dec 7, 2023
3 of 4 checks passed

h-vetinari mentioned this pull request Jan 11, 2024

MKL 2024.0 removed support for osx-64 #62

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Changes to support onemkl 2024.0 packages #61

Changes to support onemkl 2024.0 packages #61

maria-Petrova commented Dec 5, 2023 •

edited

Loading

conda-forge-webservices bot commented Dec 5, 2023

napetrov commented Dec 5, 2023

conda-forge-webservices bot commented Dec 5, 2023

napetrov commented Dec 5, 2023

github-actions bot commented Dec 5, 2023

napetrov Dec 6, 2023

oleksandr-pavlyk Dec 6, 2023

oleksandr-pavlyk Dec 6, 2023

oleksandr-pavlyk commented Dec 6, 2023

napetrov commented Dec 6, 2023

napetrov commented Dec 6, 2023

napetrov commented Dec 6, 2023

maria-Petrova commented Dec 7, 2023

maria-Petrova commented Dec 7, 2023

h-vetinari commented Jan 11, 2024

napetrov commented Jan 11, 2024

Changes to support onemkl 2024.0 packages #61

Changes to support onemkl 2024.0 packages #61

Conversation

maria-Petrova commented Dec 5, 2023 • edited Loading

conda-forge-webservices bot commented Dec 5, 2023

napetrov commented Dec 5, 2023

conda-forge-webservices bot commented Dec 5, 2023

napetrov commented Dec 5, 2023

github-actions bot commented Dec 5, 2023

napetrov Dec 6, 2023

Choose a reason for hiding this comment

oleksandr-pavlyk Dec 6, 2023

Choose a reason for hiding this comment

oleksandr-pavlyk Dec 6, 2023

Choose a reason for hiding this comment

oleksandr-pavlyk commented Dec 6, 2023

napetrov commented Dec 6, 2023

napetrov commented Dec 6, 2023

napetrov commented Dec 6, 2023

maria-Petrova commented Dec 7, 2023

maria-Petrova commented Dec 7, 2023

h-vetinari commented Jan 11, 2024

napetrov commented Jan 11, 2024

maria-Petrova commented Dec 5, 2023 •

edited

Loading