Add java and maven as a dep

[hadim]

@ctrueden @hanslovsky

I got an error during imglyb tests because maven was missing.

Are you ok adding Java and maven as a dependency of jgo?

[conda-forge-linter]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

[ctrueden]

Are you ok adding Java and maven as a dependency of jgo?

That seems proper to me, but there was some reason @hanslovsky chose not to do that earlier...

[hadim]

I see.

I really don't have a strong preference and those tools are more yours than mine anyway so it's up to you @hanslovsky.

[hadim]

FYI: I added maven as a dependency to imglyb so the lack of dependency to jgo will only affect "jgo-only" users.

[ctrueden]

I added maven as a dependency to imglyb

I would like maven and openjdk to be dependencies of scyjava. I see scyjava as a layer on top of jgo and pyjnius that makes things easy for developers to use Java.

The imglyb project depends on scyjava, so that should be fine downstream too.

[hadim]

Good idea! I'll close here then.

[hanslovsky]

Java should not be a dependency of jgo because

1. There is no JavaFX/OpenJFX on conda and running JavaFX applications with jgo would be unnecessarily complicated that way, in particular in a scenario in which the software would be shipped through conda, as well. I tried to create a conda package but I failed miserably just trying to build OpenJFX on my machine.
2. Currently, the selection of JDKs is very limited on conda, pretty much the same problem as (1).

FYI: I added maven as a dependency to imglyb so the lack of dependency to jgo will only affect "jgo-only" users.

Good catch, thank you!

[hadim]

FYI: I am also trying to update Java itself on conda-forge:

• Java 9 openjdk-feedstock#34
• Java 10 openjdk-feedstock#35
• Java 11 openjdk-feedstock#36

[hanslovsky]

Good stuff @hadim!
Java10 might be a game changer for my argument above as JavaFX is available through maven central for Java >= 10