[main] fix pkgconfig metadata on windows and tighten tests #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-vetinari
requested review from
JohanMabille,
dopplershift,
hajapy,
jakirkham,
jjerphan,
ocefpaf,
wesm,
xhochy and
xylar
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
This is going to fail. I haven't researched a fix yet, in the process of writing an upstream issue... |
h-vetinari
changed the title
|
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
copybara-service bot
pushed a commit
to protocolbuffers/protobuf
that referenced
this pull request
Feb 22, 2024
Closes #15883, tested in conda-forge/libprotobuf-feedstock#209 Closes #15888 COPYBARA_INTEGRATE_REVIEW=#15888 from h-vetinari:absl_pkgconfig 9062aa9 PiperOrigin-RevId: 609206067
3 tasks
deannagarcia
pushed a commit
to deannagarcia/protobuf
that referenced
this pull request
Jun 20, 2024
…#15888) Closes protocolbuffers#15883, tested in conda-forge/libprotobuf-feedstock#209 Closes protocolbuffers#15888 COPYBARA_INTEGRATE_REVIEW=protocolbuffers#15888 from h-vetinari:absl_pkgconfig 9062aa9 PiperOrigin-RevId: 609206067
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pkgconfig data on windows is wrong, is looking for
absl_abseil_dll, which obviously doesn't exist. Tighten the tests, then fix it.