Glibc 2.34 from alma 9 #80

h-vetinari · 2024-10-22T04:56:26Z

~~Builds on #79 and predecessors, so review those first.~~

conda-forge-admin · 2024-10-22T04:58:16Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.
I do have some suggestions for making it better though...

For recipe/meta.yaml:

License exception is not an SPDX exception.

Documentation on acceptable licenses can be found here.

h-vetinari · 2024-10-22T05:15:24Z

This is the output of the update.py,

(builder) E:\conda-forge\linux-sysroot-feedstock\recipe>python update.py
WARNING:root:Could not download rpm for glibc-headers from https://repo.almalinux.org/vault/9.3/AppStream/aarch64/os/Packages/glibc-headers-2.34-83.el9_3.12.aarch64.rpm!
WARNING:root:Could not download rpm for glibc-headers from https://repo.almalinux.org/vault/9.3/AppStream/ppc64le/os/Packages/glibc-headers-2.34-83.el9_3.12.ppc64le.rpm!

i.e. exactly two packages aren't available in the expected location w.r.t. x86_64. I've checked the other subfolders on the vault, and indeed the glibc-headers seem to be missing completely for 9.3 on aarch/ppc, and this also matches the info on pkgs.org. No idea why that's the case. Interestingly it's fine for s390x.

Edit: opened a thread on the alma discourse
Edit2: it's intentional

beckermr

Did you move the current main to an alma8 branch?

h-vetinari · 2024-10-23T23:32:45Z

Did you move the current main to an alma8 branch?

It'll be easy to create a new v2.28 branch off the current commit on main (4bead36), irrespective of whether that's before/after merging this. I can do it if you'd like, but Isuru doesn't like non-maintainers doing branch ops, so I'm holding off.

doesn't exist anymore, see https://git.almalinux.org/rpms/nss_nis/commit/d654f8c5a2a721ea5d38c26b1d12d71eda3bcfbb (there's also no c9s branch)

…rsion

…follow

beckermr · 2024-10-24T22:04:01Z

I went ahead and made a v2.28 branch. I will sync it with main if any other PRs get made there before this is merged.

beckermr

We need to add one extra feature to the build to weigh it down relative to v2.28.

beckermr

LGTM!

isuruf

What happened to libnss_nis.so?
Also I see aarch64-conda-linux-gnu/sysroot/usr/lib64/libnss_hesiod.so is a symlink with no target

h-vetinari · 2024-10-24T22:21:28Z

What happened to libnss_nis.so?

See the commit message for 6d8749d. I couldn't find anything related to that anymore (see also here).

Also I see aarch64-conda-linux-gnu/sysroot/usr/lib64/libnss_hesiod.so is a symlink with no target

Looks like we need nss_hesiod instead...

h-vetinari · 2024-10-24T22:36:16Z

~~Hm, nevermind, it was already there before my last commit, but it points to the wrong place:~~

?rwxrwxrwx 0/0          0 2024-10-24 22:09:17 aarch64-conda-linux-gnu/sysroot/usr/lib64/libnss_compat.so -> ../../lib64/libnss_compat.so.2 
?rwxrwxrwx 0/0          0 2024-10-24 22:09:17 aarch64-conda-linux-gnu/sysroot/usr/lib64/libnss_db.so -> ../../lib64/libnss_db.so.2 
?rwxrwxrwx 0/0          0 2024-10-24 22:09:17 aarch64-conda-linux-gnu/sysroot/usr/lib64/libnss_hesiod.so -> ../../lib64/libnss_hesiod.so.2

Edit: this comment was wrong; the libnss_hesiod.so symlink was there, but libnss_hesiod.so.2 only gets installed from nss_hesiod.rpm.

h-vetinari · 2024-10-24T22:56:43Z

OK, the "symlink with no target" warnings are all gone now. While I don't know what determines the separation between lib64 and usr/lib64, libnss_hesiod.so is now next to the other nss libraries:

                                              [...]
?rwxrwxr-x 0/0     904648 2024-10-24 22:45:50 x86_64-conda-linux-gnu/sysroot/lib64/libm.so.6 
?rwxrwxr-x 0/0     176840 2024-10-24 22:45:50 x86_64-conda-linux-gnu/sysroot/lib64/libmvec.so.1 
?rwxrwxr-x 0/0      45552 2024-10-24 22:45:50 x86_64-conda-linux-gnu/sysroot/lib64/libnss_compat.so.2 
?rwxrwxr-x 0/0      40872 2024-10-24 22:45:51 x86_64-conda-linux-gnu/sysroot/lib64/libnss_db.so.2 
?rwxrwxr-x 0/0      15344 2024-10-24 22:45:50 x86_64-conda-linux-gnu/sysroot/lib64/libnss_dns.so.2 
?rwxrwxr-x 0/0      15336 2024-10-24 22:45:50 x86_64-conda-linux-gnu/sysroot/lib64/libnss_files.so.2 
?rwxrwxr-x 0/0      28448 2024-10-24 22:45:51 x86_64-conda-linux-gnu/sysroot/lib64/libnss_hesiod.so.2 
?rwxrwxr-x 0/0      15480 2024-10-24 22:45:50 x86_64-conda-linux-gnu/sysroot/lib64/libpthread.so.0
                                              [...]

isuruf · 2024-10-25T17:56:33Z

Shall we remove nss components from 2.28 and 2.34 both and deal with it when there's a use-case?

beckermr · 2024-10-25T18:00:03Z

That seems fine. I don't even know why we had them in the first place. Is there someone to ask about that?

beckermr · 2024-10-25T19:24:23Z

It appears from #32 that some of the nss stuff was added due to a bug in building the ROS distro packages from work by @wolfv. Maybe he recalls what happened there?

This reverts commit d9650a7, reversing changes made to e13f355.

conda-forge-admin · 2024-10-25T20:35:47Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

license_file entry is missing, but is required.

For recipe/meta.yaml:

License exception is not an SPDX exception.

Documentation on acceptable licenses can be found here.

conda-forge-admin · 2024-10-25T20:49:13Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.
I do have some suggestions for making it better though...

For recipe/meta.yaml:

License exception is not an SPDX exception.

Documentation on acceptable licenses can be found here.

h-vetinari · 2024-10-25T20:50:09Z

Shall we remove nss components from 2.28 and 2.34 both and deal with it when there's a use-case?

Fixed in this PR; opened #83 that backports relevant commits to v2.28

isuruf · 2024-10-27T03:28:44Z

Thanks

h-vetinari mentioned this pull request Oct 22, 2024

Automate hash calculation; update sources to alma 8.9 #79

Merged

h-vetinari force-pushed the alma9 branch from 4bea949 to edea879 Compare October 23, 2024 23:13

h-vetinari marked this pull request as ready for review October 23, 2024 23:24

h-vetinari requested review from beckermr, isuruf and scopatz as code owners October 23, 2024 23:24

beckermr requested changes Oct 23, 2024

View reviewed changes

h-vetinari added 7 commits October 25, 2024 08:51

update to glibc 2.34 / alma 9.3

743a21e

drop nss_nis

6d8749d

doesn't exist anymore, see https://git.almalinux.org/rpms/nss_nis/commit/d654f8c5a2a721ea5d38c26b1d12d71eda3bcfbb (there's also no c9s branch)

update subfolders for alma 9

66688be

handle different subfolders for determining glibc & kernel-headers ve…

5a630cd

…rsion

update hashes & urls for alma 9.3

902e48f

handle absence of glibc-headers on aarch/ppc

7cdaf98

make hierarchy of if-branches for rewriting of meta.yaml easier to …

3d8a7ae

…follow

h-vetinari force-pushed the alma9 branch from ac37c39 to 3d8a7ae Compare October 24, 2024 21:51

beckermr requested changes Oct 24, 2024

View reviewed changes

fix: add one more feature

f7f701f

beckermr approved these changes Oct 24, 2024

View reviewed changes

isuruf requested changes Oct 24, 2024

View reviewed changes

add nss_hesiod

98958d3

h-vetinari added 2 commits October 25, 2024 09:40

install libhesiod in expected location

87e5c71

add tzdata in host to avoid "symlink with no target" warning

27bdd93

h-vetinari requested a review from isuruf October 24, 2024 22:58

This was referenced Oct 25, 2024

create alma9-based infrastructure conda-forge/conda-forge.github.io#2342

Closed

Add cdts for alma9; use cdt_name=conda for all distros conda-forge/cdt-builds#71

Merged

h-vetinari added 2 commits October 26, 2024 07:30

Revert "BUG add libfreebl3.so"

6c49e75

This reverts commit d9650a7, reversing changes made to e13f355.

remove nss-packages

7bae0d0

add our default infra-feedstock license

400a4d2

h-vetinari mentioned this pull request Oct 25, 2024

[v2.28] Remove nss packages #83

Merged

isuruf merged commit 2ebae6a into conda-forge:main Oct 27, 2024
7 checks passed

h-vetinari deleted the alma9 branch October 27, 2024 08:07

h-vetinari mentioned this pull request Nov 2, 2024

Use alma9 images on linux, while staying on 2.17 sysroot conda-forge/conda-forge-pinning-feedstock#6283

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Glibc 2.34 from alma 9 #80

Glibc 2.34 from alma 9 #80

h-vetinari commented Oct 22, 2024 •

edited

Loading

conda-forge-admin commented Oct 22, 2024

h-vetinari commented Oct 22, 2024 •

edited

Loading

beckermr left a comment

h-vetinari commented Oct 23, 2024 •

edited

Loading

beckermr commented Oct 24, 2024

beckermr left a comment

beckermr left a comment

isuruf left a comment

h-vetinari commented Oct 24, 2024

h-vetinari commented Oct 24, 2024 •

edited

Loading

h-vetinari commented Oct 24, 2024

isuruf commented Oct 25, 2024

beckermr commented Oct 25, 2024

beckermr commented Oct 25, 2024

conda-forge-admin commented Oct 25, 2024

conda-forge-admin commented Oct 25, 2024

h-vetinari commented Oct 25, 2024

isuruf commented Oct 27, 2024

Glibc 2.34 from alma 9 #80

Glibc 2.34 from alma 9 #80

Conversation

h-vetinari commented Oct 22, 2024 • edited Loading

conda-forge-admin commented Oct 22, 2024

h-vetinari commented Oct 22, 2024 • edited Loading

beckermr left a comment

Choose a reason for hiding this comment

h-vetinari commented Oct 23, 2024 • edited Loading

beckermr commented Oct 24, 2024

beckermr left a comment

Choose a reason for hiding this comment

beckermr left a comment

Choose a reason for hiding this comment

isuruf left a comment

Choose a reason for hiding this comment

h-vetinari commented Oct 24, 2024

h-vetinari commented Oct 24, 2024 • edited Loading

h-vetinari commented Oct 24, 2024

isuruf commented Oct 25, 2024

beckermr commented Oct 25, 2024

beckermr commented Oct 25, 2024

conda-forge-admin commented Oct 25, 2024

conda-forge-admin commented Oct 25, 2024

h-vetinari commented Oct 25, 2024

isuruf commented Oct 27, 2024

h-vetinari commented Oct 22, 2024 •

edited

Loading

h-vetinari commented Oct 22, 2024 •

edited

Loading

h-vetinari commented Oct 23, 2024 •

edited

Loading

h-vetinari commented Oct 24, 2024 •

edited

Loading