-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebuild for CUDA 12 #31
Rebuild for CUDA 12 #31
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
…nda-forge-pinning 2023.06.03.09.50.24
@conda-forge-admin, please re-render |
…nda-forge-pinning 2023.06.03.09.50.24
Rebuild for CUDA 12.
Seeing this error on CI
Think the CUDA arch environment variables need a branch for CUDA 11 / 12 (perhaps similar to magma-feedstock/recipe/build.sh Lines 6 to 8 in be97f11
More info and discussion in issue ( conda-forge/conda-forge.github.io#1963 ) |
…nda-forge-pinning 2023.06.03.09.50.24
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Daniel! 🙏
Had some suggestions below. Would be interested to hear your thoughts 🙂
export CUDA_ARCH_LIST="sm_35,sm_50,sm_60,sm_61,sm_70,sm_75,sm_80" | ||
export CUDAARCHS="35-virtual;50-virtual;60-virtual;61-virtual;70-virtual;75-virtual;80-virtual" | ||
|
||
if [[ "$cuda_compiler_version" == "12.0" ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would suggest making CUDA 11 the special case. The advantage being that when we drop it, we can just delete som lines from the recipe. Also it will make adding new CUDA 12.x's easier
export CUDA_ARCH_LIST="sm_35,sm_50,sm_60,sm_61,sm_70,sm_75,sm_80" | ||
export CUDAARCHS="35-virtual;50-virtual;60-virtual;61-virtual;70-virtual;75-virtual;80-virtual" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can define common versions here and append or prepend others in the conditionals?
export CUDA_ARCH_LIST="sm_35,sm_50,sm_60,sm_61,sm_70,sm_75,sm_80" | |
export CUDAARCHS="35-virtual;50-virtual;60-virtual;61-virtual;70-virtual;75-virtual;80-virtual" | |
export CUDA_ARCH_LIST="sm_50,sm_60,sm_61,sm_70,sm_75,sm_80" | |
export CUDAARCHS="50-virtual;60-virtual;61-virtual;70-virtual;75-virtual;80-virtual" |
Manually adding a CUDA 12 migration PR since the bot ran into some issues generating it.
Hi! This is the friendly automated conda-forge-webservice.
I've started rerendering the recipe as instructed in #30.
If I find any needed changes to the recipe, I'll push them to this PR shortly. Thank you for waiting!
Here's a checklist to do before merging.
Fixes #30