Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for CUDA 12 #31

Merged
merged 9 commits into from
Jun 6, 2023

Conversation

conda-forge-admin
Copy link
Contributor

@conda-forge-admin conda-forge-admin commented Jun 3, 2023

Manually adding a CUDA 12 migration PR since the bot ran into some issues generating it.


Hi! This is the friendly automated conda-forge-webservice.

I've started rerendering the recipe as instructed in #30.

If I find any needed changes to the recipe, I'll push them to this PR shortly. Thank you for waiting!

Here's a checklist to do before merging.

  • Bump the build number if needed.

Fixes #30

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

conda-forge-webservices[bot] and others added 2 commits June 3, 2023 22:29
@jakirkham
Copy link
Member

@conda-forge-admin, please re-render

conda-forge-webservices[bot] and others added 2 commits June 3, 2023 22:34
Rebuild for CUDA 12.
@jakirkham jakirkham changed the title MNT: rerender Rebuild for CUDA 12 Jun 3, 2023
@jakirkham
Copy link
Member

Seeing this error on CI

Unsupported gpu architecture 'compute_35'

Think the CUDA arch environment variables need a branch for CUDA 11 / 12 (perhaps similar to libmagma)

# Duplicate lists because of https://bitbucket.org/icl/magma/pull-requests/32
export CUDA_ARCH_LIST="sm_35,sm_50,sm_60,sm_70,sm_80"
export CUDAARCHS="35-virtual;50-virtual;60-virtual;70-virtual;80-virtual"

More info and discussion in issue ( conda-forge/conda-forge.github.io#1963 )

Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Daniel! 🙏

Had some suggestions below. Would be interested to hear your thoughts 🙂

export CUDA_ARCH_LIST="sm_35,sm_50,sm_60,sm_61,sm_70,sm_75,sm_80"
export CUDAARCHS="35-virtual;50-virtual;60-virtual;61-virtual;70-virtual;75-virtual;80-virtual"

if [[ "$cuda_compiler_version" == "12.0" ]]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would suggest making CUDA 11 the special case. The advantage being that when we drop it, we can just delete som lines from the recipe. Also it will make adding new CUDA 12.x's easier

Comment on lines +9 to +10
export CUDA_ARCH_LIST="sm_35,sm_50,sm_60,sm_61,sm_70,sm_75,sm_80"
export CUDAARCHS="35-virtual;50-virtual;60-virtual;61-virtual;70-virtual;75-virtual;80-virtual"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can define common versions here and append or prepend others in the conditionals?

Suggested change
export CUDA_ARCH_LIST="sm_35,sm_50,sm_60,sm_61,sm_70,sm_75,sm_80"
export CUDAARCHS="35-virtual;50-virtual;60-virtual;61-virtual;70-virtual;75-virtual;80-virtual"
export CUDA_ARCH_LIST="sm_50,sm_60,sm_61,sm_70,sm_75,sm_80"
export CUDAARCHS="50-virtual;60-virtual;61-virtual;70-virtual;75-virtual;80-virtual"

@carterbox carterbox merged commit abc21f9 into conda-forge:main Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@conda-forge-admin, please re-render
3 participants