-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebuild 0.12.15 for python 3.11 #100
base: main
Are you sure you want to change the base?
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
I forgot about all of the problems we had with some of the later |
@messense @apcamargo -- It looks like everything is passing on this now. How do you want to handle this? |
I'm fine with merging this, but I don't know the process to handle old versions. |
I've opened sfu-db/connector-x#523 to upgrade maturin to 1.0 for |
I guess there are two options. One is to merge this into another branch, which will get built automatically. The other is to merge it into |
Would it be possible to merge this PR? Also, would it be possible to add 3.12 support? I am working on |
Doesn't pybip39 require >14,<15 (https://github.com/polkascan/py-bip39-bindings/blob/master/pyproject.toml#L2)? Or are you working on an older version? It looks like after I put in this PR, @xhochy took the strategy of setting up a 0.14 branch to get py3.12 support, so I guess we could do that with 0.12 as well if needed. |
Though, that is a great point, both of those are supposed to be doing the same thing and I actually only need |
Well, I will simply remove the failing tests, |
Just FYI, it turns out that the Cargo.toml requests PyO3=0.15.1 with features that within conda-build defaults to 0.15.2, with which the compilation fails. |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)This is an older version of maturin that we don't currently have on conda-forge. I'm attempting to build it since
connectorx
pins to>=0.12,<0.13
, but the available builds satisfying that (latest is0.12.15
) on conda-forge currently don't support python 3.11. This is blockingconnectorx
from building on python 3.11.connectorx
is used bypolars
andmodin
for pulling data from a database into a dataframe. This was the last version of pypi before0.13.0
.I'm not sure if this should be merged into
main
or a separate branch.