Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable pkg installers #434

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

enable pkg installers #434

wants to merge 13 commits into from

Conversation

jaimergp
Copy link
Member

@jaimergp jaimergp commented Mar 2, 2023

Closes #429

Tasklist

  • Enable PKG artifactsx
  • Custom background
  • Custom welcome text
  • Custom readme text (if any)
  • Custom conclusion text (if any)
  • Set up certificates
  • Signing
  • Notarization
  • Validation
  • Tests

Welcome screenshot:

image

image

@jaimergp
Copy link
Member Author

jaimergp commented Mar 2, 2023

The artifacts are available and include the PKG installers. This PR is not done (see description), but those should be functional already. Please let me know if you have any feedback!

@psobolewskiPhD
Copy link
Member

psobolewskiPhD commented Feb 15, 2024

Looks great!
But, the artifacts are expired 😢
edit: nvm, they're here https://github.com/conda-forge/miniforge/actions/runs/7915666236
BTW bit of a bummer that they require admin to run 😢 that could just be an issue with the apple pkg installer though.

@jaimergp
Copy link
Member Author

Check these ones: https://github.com/conda-forge/miniforge/actions/runs/7915666236

I don't think they require superuser per se, but maybe there's a bug. Let me know.

@psobolewskiPhD
Copy link
Member

Yea I found the right artifacts, tried the mini forge-arm64 and it did require admin.
I will try to test on my personal machine later where I have admin, but I can't on my work one.

@yuvipanda
Copy link
Contributor

So first, it doesn't wanna open because it's not signed and apple hates us.

Screen Shot 2024-02-15 at 10 09 00 AM

I went into security settings and allowed it explicitly (required admin), so the dialog box got less scary:
image

It allowed me to install it just on my home directory
image

Failed the first time because I already have it installed
image

But it works now, after!

So I suppose it needs to be signed?

Thanks for working on this, @jaimergp!

@jaimergp
Copy link
Member Author

Yes, the signing machinery is there in constructor (thanks napari!), we just need the Apple certificate from NumFocus.

@jaimergp
Copy link
Member Author

Also, if you have feedback about the messaging, we can customize some steps.

@yuvipanda
Copy link
Contributor

Only suggestion is to maybe have something in there about pre-existing installations? But that's very minor, as the target audience for this probably does not have pre-existing installations.

@hmaarrfk
Copy link
Contributor

as the target audience for this probably does not have pre-existing installations.

I think this is a fair first approximation.

However, I think we get many questions on this issue tracker where people have trouble installing miniforge when Miniconda or Anaconda is already installed (and to a lesser extent when miniforge or mambaforge is already installed).

@hmaarrfk hmaarrfk mentioned this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment