Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 24.1 #571

Merged
merged 1 commit into from
Mar 24, 2024
Merged

Update to 24.1 #571

merged 1 commit into from
Mar 24, 2024

Conversation

hmaarrfk
Copy link
Contributor

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@hmaarrfk hmaarrfk requested a review from a team as a code owner March 22, 2024 10:39
@mbargull
Copy link
Member

Since we have conda=24.3.0 already released upstream and I expect us to build conda-forge::conda=24.3.0 next week, maybe wait on that?
Not that it'd be bad to have 24.1-based installers; just seems odd to do it now :D.

@hmaarrfk
Copy link
Contributor Author

i was confused as to why i thought i read your message badly. this can wait for 24.3. I guess it just didn't get released on conda-forge.

Not that it'd be bad to have 24.1-based installers; just seems odd to do it now :D.

We might find a bunch of bugs with 24.3. Historically Miniforge releases always had to wait for the dust to settle. So if this would have helped jakirkham, I would consider this a win right?

@hmaarrfk
Copy link
Contributor Author

I'll leave this up till sunday or so, and I'll probably release unless I hear a strong objection or 24.3 gets released first

@mbargull
Copy link
Member

mbargull commented Mar 22, 2024

hear a strong objection

None from my side.

or 24.3 gets released first

We'll build conda-build after the weekend and I'd expect conda to follow quickly.
We just avoid pushing out those build right before or during the weekend to not force anyone to fix issues during that time in case something does break.

@hmaarrfk hmaarrfk merged commit 8336419 into conda-forge:main Mar 24, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants