Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize macOS naming in README.md #652

Merged
merged 4 commits into from
Sep 29, 2024
Merged

Conversation

amorehead
Copy link
Contributor

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@amorehead amorehead requested a review from a team as a code owner September 28, 2024 22:01
@hmaarrfk
Copy link
Contributor

Thank you! This is a welcome change, but you seem to only be adding "more variants".

@amorehead
Copy link
Contributor Author

Ah, good point. I'll fix that now.

@hmaarrfk
Copy link
Contributor

Try to go even further, there are a few references to OS X

@amorehead
Copy link
Contributor Author

I think I got most of them, the only ones I can't update are the download URLs.

@hmaarrfk
Copy link
Contributor

I think I got most of them, the only ones I can't update are the download URLs.

Actually reverted the one to the "filename previews". I guess for the things that allude to the download names we can't really change, but for what refers to the operating system in prose we can.

@hmaarrfk hmaarrfk merged commit e00f412 into conda-forge:main Sep 29, 2024
24 checks passed
@hmaarrfk
Copy link
Contributor

Thanks!

@amorehead amorehead deleted the patch-1 branch September 29, 2024 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants