Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate PyPy3 installers #657

Merged
merged 3 commits into from
Oct 12, 2024
Merged

Conversation

hmaarrfk
Copy link
Contributor

@hmaarrfk hmaarrfk commented Oct 6, 2024

Gonna leave this up here for 1 week for comments ahead of cutting a release:

Closes #656

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@hmaarrfk hmaarrfk requested a review from a team as a code owner October 6, 2024 14:22
@hmaarrfk hmaarrfk mentioned this pull request Oct 6, 2024
5 tasks
Co-authored-by: jaimergp <jaimergp@users.noreply.github.com>
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mark! 🙏

Added a suggestion below

Comment on lines +3 to +16
if [[ "$GITHUB_ACTIONS" == "true" ]]; then
echo "::warning title=Mambaforge is now deprecated!::Future Miniforge releases will NOT build Mambaforge installers. We advise you switch to Miniforge at your earliest convenience. More details at https://conda-forge.org/news/2024/07/29/sunsetting-mambaforge/."
else
echo "!!!!!! Conda-Forge PyPy is now deprecated !!!!!"
echo "Future Miniforge releases will NOT build with PyPy in the base environment installers."
echo "We advise you switch to Miniforge3 at your earliest convenience."
echo "More details at https://conda-forge.org/news/2024/08/14/sunsetting-pypy/"
echo "If you are unable to switch to Miniforge, you may pin your installer version to one found in "
echo "https://github.com/conda-forge/miniforge/releases/tag/24.3.0-1"
echo "or if you lack the system requirements (Linux glibc >= 2.17, or macOS + x86-64bit >= 10.13)"
echo "you may pin your installer to one older version found in "
echo "https://github.com/conda-forge/miniforge/releases/tag/24.3.0-0"
echo "This Miniforge installer will ceese to work in 2025."
fi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's put this in a text file that ships with the installer. Then all platforms can echo the test file and we can get the wording to match with both

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather not overbuild for a depreation that will only last 3 months.

The challenge is that the wording MUST be different for different platforms.

Windows, linux, and OSX have different recommendations.

Generic recommendations REALLY confuse first time users.

Is there a word here that you are concerned with getting correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My windows skills are also seriously lacking..... so I would rather not try something new....

My main goal for this week is to give time for somebody that might care for this installer to stepup, but not to create more organizational work. "2" notices is not enough to reorganize things IMO.

@hmaarrfk hmaarrfk merged commit 2bab034 into conda-forge:main Oct 12, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance of the PyPy installers
3 participants