Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch build backend to hatchling #132

Closed
hoechenberger opened this issue May 26, 2024 · 4 comments · Fixed by #133
Closed

Switch build backend to hatchling #132

hoechenberger opened this issue May 26, 2024 · 4 comments · Fixed by #133
Assignees

Comments

@hoechenberger
Copy link
Member

hoechenberger commented May 26, 2024

For whatever obscure reason, our builds here are working even though we're not installing all required build deps (still using setuptools instead of hatchling)

The host requirements should be updated to include

    - hatchling
    - hatch-vcs

@larsoner would you like to give it a shot if you have time?

@larsoner
Copy link
Contributor

I can look tomorrow. No idea why it works currently!

@hoechenberger hoechenberger self-assigned this May 26, 2024
@larsoner
Copy link
Contributor

Not tomorrow, Tuesday

@hoechenberger
Copy link
Member Author

hoechenberger commented May 26, 2024

@conda-forge/python Hello! We'd just like to bring your attention to the fact that this package's build backend was changed to hatchling (with hatch-vcs) upstream, and we forgot to update the feedstock – it would install pip, setuptools, setuptools-scm, and git; i.e., the new build deps were missing. However, builds still succeeded! We were wondering if this points to a problem with build isolation on conda-forge?

@xhochy
Copy link
Member

xhochy commented May 27, 2024

You ran into conda/conda-build#3993

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants