-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combine multiple migrations #23
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
Documentation on acceptable licenses can be found here. |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
Documentation on acceptable licenses can be found here. |
…da-forge-pinning 2020.12.19.03.20.16
@conda-forge-admin, please rerender |
…da-forge-pinning 2020.12.20.03.10.16
For some reason the Linux build is only for boost-cpp 1.74 while Mac OS X is build for 1.72 and 1.74 - for now I restricted mshr to 1.74 and higher |
recipe/meta.yaml
Outdated
@@ -26,18 +26,18 @@ requirements: | |||
- {{ compiler('c') }} | |||
- {{ compiler('cxx') }} | |||
host: | |||
- boost-cpp | |||
- boost-cpp >=1.74 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would remove the global pinning
recipe/meta.yaml
Outdated
@@ -26,18 +26,18 @@ requirements: | |||
- {{ compiler('c') }} | |||
- {{ compiler('cxx') }} | |||
host: | |||
- boost-cpp | |||
- boost-cpp >=1.74 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change? This will hinder future boost-cpp
migrations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Isuru always faster :D)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From above: For some reason the Linux build is only for boost-cpp 1.74 while Mac OS X is build for 1.72 and 1.74 - for now I restricted mshr to 1.74 and higher
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd assume this was only a misinterpretation of the selector which reads "do boost 1.72 and 1.74, unless on ARM Macs, for those only 1.74".
@conda-forge-admin, please rerender |
…da-forge-pinning 2020.12.21.13.42.08
When I remove the boost restriction the boost 1.72 builds fail. The reason is that |
Hopefully this is going to be fixed by conda-forge/fenics-feedstock#123 |
We get the error:
Which is the same the users report in #18 My suggestion is to separate the two boost builds more strictly: conda-forge/fenics-feedstock#124 |
The failed builds show different builds for the |
I hope this is fixed with the build 15 - still
So you mean using |
I created a corresponding pull request conda-forge/fenics-feedstock#126 |
If that's needed, yes. Might not be needed (I don't know these packages at all) if they are just loosely coupled (e.g., no linking etc.). |
@conda-forge-admin restart ci |
@conda-forge-admin restart ci |
boost 1.72 on linux in combination with python 3.6, python 3.7 or python 3.8 fails - while it works fine for python 3.9 |
Can somebody help me to resolve this dependency issue:
|
@conda-forge-admin restart ci |
@conda-forge-admin restart ci |
From my perspective this is ready to be merged now |
Co-authored-by: Isuru Fernando <isuruf@gmail.com>
Co-authored-by: Isuru Fernando <isuruf@gmail.com>
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)