Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nnpops v0.4 #16

Merged
merged 5 commits into from
Mar 6, 2023
Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

@regro-cf-autotick-bot regro-cf-autotick-bot commented Mar 3, 2023

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/4323034337, please use this URL for debugging.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@raimis raimis mentioned this pull request Mar 3, 2023
@mikemhenry
Copy link
Contributor

@raimis I've got a failure here, is the tolerance too tight or is there an issue perhaps?

=================================== FAILURES ===================================
__________________ test_compare_waterbox_pbc_with_native[cpu] __________________

deviceString = 'cpu'
        from NNPOps import OptimizedTorchANI
    
        device = torch.device(deviceString)
    
        mol = mdtraj.load(os.path.join(molecules, 'water.pdb'))
        atomicNumbers = torch.tensor([[atom.element.atomic_number for atom in mol.top.atoms]], device=device)
        atomicPositions = torch.tensor(mol.xyz * 10, dtype=torch.float32, requires_grad=True, device=device)
        cell = mol.unitcell_vectors[0]
        cell = torch.tensor(cell, dtype=torch.float32, device=device)*10.0
        pbc = torch.tensor([True, True, True], dtype=torch.bool, device=device)
    
        nnp = torchani.models.ANI2x(periodic_table_index=True).to(device)
        energy_ref = nnp((atomicNumbers, atomicPositions), cell=cell, pbc=pbc).energies
        energy_ref.backward()
        grad_ref = atomicPositions.grad.clone()
    
        nnp = OptimizedTorchANI(nnp, atomicNumbers).to(device)
        energy = nnp((atomicNumbers, atomicPositions), cell=cell, pbc=pbc).energies
        atomicPositions.grad.zero_()
        energy.backward()
        grad = atomicPositions.grad.clone()
    
        energy_error = torch.abs((energy - energy_ref)/energy_ref)
        grad_error = torch.max(torch.abs((grad - grad_ref)/grad_ref))
    
        assert energy_error < 5e-7
>       assert grad_error < 7e-3
E       assert tensor(0.0074) < 0.007

../src/pytorch/TestOptimizedTorchANI.py:100: AssertionError

@raimis raimis self-requested a review as a code owner March 6, 2023 10:56
@raimis raimis self-assigned this Mar 6, 2023
@raimis
Copy link
Contributor

raimis commented Mar 6, 2023

@conda-forge-admin please rerender

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/nnpops-feedstock/actions/runs/4345750966.

@raimis
Copy link
Contributor

raimis commented Mar 6, 2023

@mikemhenry @h-vetinari could you review?

Copy link
Contributor

@mikemhenry mikemhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the patch and the note when to remove it :)

@mikemhenry mikemhenry merged commit 1dadb4a into conda-forge:main Mar 6, 2023
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 0.4_h38e693 branch March 6, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants