Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CUDA 11.8 cross-compilation support #99

Merged

Conversation

jakirkham
Copy link
Member

Enable builds of the nvcc wrapper script for CUDA 11.8 cross-compilation support on other architectures.


Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari
Copy link
Member

It seems https://github.com/conda-forge/conda-forge-ci-setup-feedstock/blob/main/recipe/install_cuda.bat needs an update for CUDA 11.6 & 11.7, but this PR should be fine to merge for now (there's a quasi-circular dependency with the ci-setup, so IMO fine to accept slightly red CI here)

@leofang
Copy link
Member

leofang commented Aug 31, 2023

It seems https://github.com/conda-forge/conda-forge-ci-setup-feedstock/blob/main/recipe/install_cuda.bat needs an update for CUDA 11.6 & 11.7, but this PR should be fine to merge for now (there's a quasi-circular dependency with the ci-setup, so IMO fine to accept slightly red CI here)

@h-vetinari I submitted conda-forge/conda-forge-ci-setup-feedstock#265, let's see if that fixes the issue.

@h-vetinari h-vetinari added the automerge Merge the PR when CI passes label Aug 31, 2023
@jakirkham
Copy link
Member Author

jakirkham commented Aug 31, 2023

Restarted CI in the hopes that conda-forge-ci-setup packages are on CDN already. Though I guess we will see if that's true

Edit: So far it looks promising

@github-actions github-actions bot merged commit 008491c into conda-forge:main Aug 31, 2023
70 checks passed
@github-actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants