-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix qhull not being found #30
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
…da-forge-pinning 2021.01.20.17.38.08
Hi! This is the friendly automated conda-forge-linting service. I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
qhull is now found correctly after pinning:
I would say let's merge this, and then we can remove the pin once conda-forge/qhull-feedstock#12 is resolved |
Thanks to @traversaro's comments in conda-forge/qhull-feedstock#12 I decided to go for the proper fix instead, i.e. backporting PointCloudLibrary/pcl#4540 It finds QHull correctly, let's see whether the build passes. |
Thanks again @Tobias-Fischer. Glad to see this is at least on the path to being fixed in PCL already. |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)Fix #29