Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix qhull not being found #30

Merged
merged 8 commits into from
Jan 22, 2021
Merged

Fix qhull not being found #30

merged 8 commits into from
Jan 22, 2021

Conversation

Tobias-Fischer
Copy link
Contributor

@Tobias-Fischer Tobias-Fischer commented Jan 20, 2021

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Fix #29

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@Tobias-Fischer
Copy link
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@Tobias-Fischer
Copy link
Contributor Author

qhull is now found correctly after pinning:

-- Found Qhull: optimized;$PREFIX/lib/libqhull_p.so;debug;$PREFIX/lib/libqhull_p.so  
-- QHULL found (include: $PREFIX/include, lib: optimized;$PREFIX/lib/libqhull_p.so;debug;$PREFIX/lib/libqhull_p.so)

I would say let's merge this, and then we can remove the pin once conda-forge/qhull-feedstock#12 is resolved

@Tobias-Fischer Tobias-Fischer changed the title Fix qhull not being found by pinning it [WIP]Fix qhull not being found by pinning it Jan 21, 2021
@Tobias-Fischer Tobias-Fischer changed the title [WIP]Fix qhull not being found by pinning it [WIP] Fix qhull not being found Jan 21, 2021
@Tobias-Fischer
Copy link
Contributor Author

Thanks to @traversaro's comments in conda-forge/qhull-feedstock#12 I decided to go for the proper fix instead, i.e. backporting PointCloudLibrary/pcl#4540

It finds QHull correctly, let's see whether the build passes.

@Tobias-Fischer Tobias-Fischer changed the title [WIP] Fix qhull not being found Fix qhull not being found Jan 22, 2021
@Tobias-Fischer
Copy link
Contributor Author

This is now ready to be merged @hobu @chambbj

@chambbj chambbj merged commit 835013c into conda-forge:master Jan 22, 2021
@chambbj
Copy link
Contributor

chambbj commented Jan 22, 2021

Thanks again @Tobias-Fischer. Glad to see this is at least on the path to being fixed in PCL already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: qhull not found
3 participants