Finish cuda migration, fixes for linter #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no longer need special skip
…nda-forge-pinning 2024.11.26.07.33.56
minrk
requested review from
SylvainCorlay,
dalcinl,
davidbrochart,
jan-janssen,
martinRenou,
matthiasdiener and
stefanozampini
as code owners
This comment was marked as outdated.
This comment was marked as outdated.
- can only parse if conditionals are not indented - fewer conditionals, instead set variables - make sure variables we use are 'defined'
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
minrk
commented
Nov 26, 2024
| @@ -94,22 +103,22 @@ requirements: | |||
| - fftw * mpi_{{ mpi }}_* | |||
| - cuda-version {{ cuda_compiler_version }} # [cuda_compiler_version != "None"] | |||
| - cudatoolkit # [(cuda_compiler_version or "").startswith("11")] | |||
| {% if cuda_major >= 12 %} | |||
| {% if cuda_major >= 12 %} | |||
There was a problem hiding this comment.
The currently used parser doesn't handle jinja conditions when they are indented. This is a bug: conda-incubator/conda-recipe-manager#258
…nda-forge-pinning 2024.12.02.07.41.41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
didn't happen automatically since I think we had patches in the migrator