Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch to fix issue with DatabaseContext #130

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

xylar
Copy link
Contributor

@xylar xylar commented Jan 16, 2023

This is preventing pyproj from updating to this version of proj. This, in turn, is tangling up downstream packages.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

This is preventing `pyproj` from updating to this version of `proj`.
This, in turn, is tangling up downstream packages.
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@xylar
Copy link
Contributor Author

xylar commented Jan 16, 2023

@conda-forge-admin, please rerender

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/proj.4-feedstock/actions/runs/3933391692.

@xylar
Copy link
Contributor Author

xylar commented Jan 16, 2023

@xylar
Copy link
Contributor Author

xylar commented Jan 16, 2023

@snowman2, the patch seems to have worked fine here. Let me know if you have any concerns. If there's an easy way to test if it worked as expected here, I'm happy to add that but if the test is to try to build pyproj, that's also fine with me.

@xylar
Copy link
Contributor Author

xylar commented Jan 16, 2023

@conda-forge/proj-4, let me know if you have any concerns.

@snowman2
Copy link
Member

If there's an easy way to test if it worked as expected here, I'm happy to add that but if the test is to try to build pyproj, that's also fine with me.

I think that testing it with pyproj should be sufficient. I think that there was a test added in the PROJ repo that may be helpful here.

@snowman2
Copy link
Member

Thanks @xylar 👍

@xylar
Copy link
Contributor Author

xylar commented Jan 17, 2023

Thanks for the feedback @snowman2. I looked around and didn't see any obviously related tests added to PROJ but I will freely admit that I don't know my way around very well. I think we can let pyproj be the test.

@xylar xylar merged commit ab60a17 into conda-forge:main Jan 17, 2023
@xylar xylar deleted the patch_issue_with_database_context branch January 17, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants