-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch to fix issue with DatabaseContext
#130
Patch to fix issue with DatabaseContext
#130
Conversation
This is preventing `pyproj` from updating to this version of `proj`. This, in turn, is tangling up downstream packages.
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/proj.4-feedstock/actions/runs/3933391692. |
@snowman2, the patch seems to have worked fine here. Let me know if you have any concerns. If there's an easy way to test if it worked as expected here, I'm happy to add that but if the test is to try to build |
@conda-forge/proj-4, let me know if you have any concerns. |
I think that testing it with pyproj should be sufficient. I think that there was a test added in the PROJ repo that may be helpful here. |
Thanks @xylar 👍 |
Thanks for the feedback @snowman2. I looked around and didn't see any obviously related tests added to PROJ but I will freely admit that I don't know my way around very well. I think we can let |
This is preventing
pyproj
from updating to this version ofproj
. This, in turn, is tangling up downstream packages.Checklist
conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)