Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release matplotlib base version #28

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

riley-brady
Copy link

@riley-brady riley-brady commented Mar 5, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Having a hard upper bound on matplotlib-base is causing a lot of conflicts with latest versions of other major packages.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@riley-brady
Copy link
Author

@conda-forge-admin, please rerender

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Mar 5, 2024

In my experience proplot has had incompatibilities with newer versions of matplotlib:

AttributeError: module 'matplotlib.cm' has no attribute 'cmap_d'

Their main github veresion has an upperbound of 3.6 instead of 3.5 so i feel like they are approaching things with caution.

Maybe ask for a new release?

@riley-brady
Copy link
Author

Thanks @hmaarrfk -- I'm realizing this is a proplot incompatibility with newer matplotlib now. @lukelbd is busy with his postdoc so I'm not sure how much active development is going on here. I might see if it's a straight-forward fix to fix those cmap_d references and push for a new release.

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Mar 5, 2024

we have been quite lax at conda-forge pushing patched versions.

I don't realy like to do when we have the upstream maintainer involved ;)

I would suggest:

  1. Likely making a PR upstream.
  2. Pulling the patches that they already wrote for 3.5 compatibility.
  3. Leaving this PR open.

But on your machine you can:

python build-locally.py

if you don't have linux, you can use store_build_artifacts

https://github.com/conda-forge/python-feedstock/blob/897c158c0a7069c64bd81141606a3869a6d210f4/conda-forge.yml#L12

to have azure upload them for you.

With enough click, you can get to them and upload the patched version to your own anaconda channel

@riley-brady
Copy link
Author

we have been quite lax at conda-forge pushing patched versions.

I don't realy like to do when we have the upstream maintainer involved ;)

I would suggest:

  1. Likely making a PR upstream.
  2. Pulling the patches that they already wrote for 3.5 compatibility.
  3. Leaving this PR open.

But on your machine you can:

python build-locally.py

if you don't have linux, you can use store_build_artifacts

https://github.com/conda-forge/python-feedstock/blob/897c158c0a7069c64bd81141606a3869a6d210f4/conda-forge.yml#L12

to have azure upload them for you.

With enough click, you can get to them and upload the patched version to your own anaconda channel

Thanks! Have step 1 in progress now: proplot-dev/proplot#450.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants