-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the wrong v0.0.0 version number #15
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Cool. Could you add @willschlitzer to recipe/meta.yaml too as mentioned in #14 (comment)? |
Will do it later. The changes above still don't work. I'm wondering do we also need to add these dependencies (https://github.com/conda-forge/pint-feedstock/pull/34/files)
|
Those appear to be host (i.e. build) dependencies, should be ok to add them. |
Output from the CI job:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, hopefully this is the last of the drama in release v0.3.0!
P.S. Remember to use squash and merge.
Problem with setuptools_scm not getting correct version. PR is based on conda-forge/pint-feedstock#34.
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)