Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the wrong v0.0.0 version number #15

Merged
merged 3 commits into from
Feb 15, 2021
Merged

Fix the wrong v0.0.0 version number #15

merged 3 commits into from
Feb 15, 2021

Conversation

seisman
Copy link
Contributor

@seisman seisman commented Feb 15, 2021

Problem with setuptools_scm not getting correct version. PR is based on conda-forge/pint-feedstock#34.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@weiji14
Copy link
Member

weiji14 commented Feb 15, 2021

Cool. Could you add @willschlitzer to recipe/meta.yaml too as mentioned in #14 (comment)?

@seisman
Copy link
Contributor Author

seisman commented Feb 15, 2021

Cool. Could you add @willschlitzer to recipe/meta.yaml too as mentioned in #14 (comment)?

Will do it later.

The changes above still don't work. I'm wondering do we also need to add these dependencies (https://github.com/conda-forge/pint-feedstock/pull/34/files)

    - setuptools >=45
    - setuptools_scm >=3.4
    - toml

@weiji14
Copy link
Member

weiji14 commented Feb 15, 2021

Those appear to be host (i.e. build) dependencies, should be ok to add them.

@seisman
Copy link
Contributor Author

seisman commented Feb 15, 2021

Output from the CI job:

python -c 'import pygmt; pygmt.show_versions()'
PyGMT information:
  version: v0.3.0
System information:
  python: 3.9.1 | packaged by conda-forge | (default, Jan 26 2021, 01:34:10)  [GCC 9.3.0]
  executable: $PREFIX/bin/python
  machine: Linux-4.15.0-1106-azure-x86_64-with-glibc2.12
Dependency information:
  numpy: 1.20.1
  pandas: 1.2.2
  xarray: 0.16.2
  netCDF4: 1.5.6
  packaging: 20.9
  ghostscript: 9.53.3
  gmt: 6.1.1
GMT library information:
  binary dir: $PREFIX/bin
  cores: 2
  grid layout: rows
  library path: $PREFIX/lib/libgmt.so
  padding: 2
  plugin dir: $PREFIX/lib/gmt/plugins
  share dir: $PREFIX/share/gmt
  version: 6.1.1

@seisman seisman marked this pull request as ready for review February 15, 2021 22:06
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, hopefully this is the last of the drama in release v0.3.0!

P.S. Remember to use squash and merge.

@seisman seisman merged commit 7f51581 into conda-forge:master Feb 15, 2021
@seisman seisman deleted the fix-v0.0.0-version branch February 15, 2021 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants