Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Use noarch python {{ python_min }} variable #28

Merged

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Nov 8, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • [N/A] Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

* Use 'python {{ python_min }}' syntax for the python requirements for noarch
  python recipes.
   - c.f. https://conda-forge.org/docs/maintainer/knowledge_base/#noarch-python
* Add recipe/conda_build_config.yaml to override the global python_min with pyhf's
  python_min of 3.7.
* Add conda-forge/scikit-hep as feedstock maintainers.
* Bump build number.
@matthewfeickert matthewfeickert self-assigned this Nov 8, 2024
@matthewfeickert
Copy link
Member Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@matthewfeickert
Copy link
Member Author

matthewfeickert commented Nov 8, 2024

It seems that https://github.com/conda-forge/hatchling-feedstock/ has broken metadata as the last version that was compatible with Python 3.7 was v1.17.1

$ docker run --rm -ti python:3.7 /bin/bash
root@c139bfa11d98:/# python -m venv venv && . venv/bin/activate && python -m pip --quiet install --upgrade pip
(venv) root@c139bfa11d98:/# python -m pip index versions hatchling
WARNING: pip index is currently an experimental command. It may be removed/changed in a future release without prior warning.
hatchling (1.17.1)
Available versions: 1.17.1, 1.17.0, 1.16.1, 1.16.0, 1.15.0, 1.14.1, 1.14.0, 1.13.0, 1.12.2, 1.12.1, 1.12.0, 1.11.1, 1.11.0, 1.10.0, 1.9.0, 1.8.1, 1.8.0, 1.7.1, 1.7.0, 1.6.0, 1.5.0, 1.4.1, 1.3.1, 1.3.0, 1.2.0, 1.1.0, 1.0.0, 0.25.1, 0.25.0, 0.24.0, 0.23.0, 0.22.0, 0.21.1, 0.21.0, 0.20.1, 0.20.0, 0.19.0, 0.18.0, 0.17.0, 0.16.0, 0.15.0, 0.14.0, 0.13.0, 0.12.0, 0.11.3, 0.11.2, 0.11.1, 0.11.0, 0.10.0, 0.9.0, 0.8.2, 0.8.1, 0.8.0

as after that pypa/hatch#1386 introduced Python 3.8+ syntax that made its way into hatchling v1.23.0 onward. But on conda-forge Python 3.7 is able to install hatchling v1.25.0:

requirements:
  host:
    - _libgcc_mutex 0.1 conda_forge
    - ca-certificates 2024.8.30 hbcca054_0
    - ld_impl_linux-64 2.43 h712a8e2_2
    - python_abi 3.7 4_cp37m
    - libgomp 14.2.0 h77fa898_1
    - _openmp_mutex 4.5 2_gnu
    - libgcc 14.2.0 h77fa898_1
    - libgcc-ng 14.2.0 h69a702a_1
    - libstdcxx 14.2.0 hc0a3c3a_1
    - libzlib 1.3.1 hb9d3cd8_2
    - openssl 3.3.2 hb9d3cd8_0
    - libffi 3.4.2 h7f98852_5
    - libnsl 2.0.1 hd590300_0
    - libsqlite 3.47.0 hadc24fc_1
    - libstdcxx-ng 14.2.0 h4852527_1
    - ncurses 6.5 he02047a_1
    - tk 8.6.13 noxft_h4845f30_101
    - xz 5.2.6 h166bdaf_0
    - readline 8.2 h8228510_1
    - sqlite 3.47.0 h9eae976_1
    - python 3.7.12 hf930737_100_cpython
    - editables 0.5 pyhd8ed1ab_0
    - packaging 23.2 pyhd8ed1ab_0
    - pathspec 0.12.1 pyhd8ed1ab_0
    - setuptools 69.0.3 pyhd8ed1ab_0
    - tomli 2.0.2 pyhd8ed1ab_0
    - trove-classifiers 2024.10.21.16 pyhd8ed1ab_0
    - typing_extensions 4.7.1 pyha770c72_0
    - wheel 0.42.0 pyhd8ed1ab_0
    - zipp 3.15.0 pyhd8ed1ab_0
    - importlib-metadata 4.11.4 py37h89c1867_0
    - pip 24.0 pyhd8ed1ab_0
    - typing-extensions 4.7.1 hd8ed1ab_0
    - importlib_metadata 4.11.4 hd8ed1ab_0
    - setuptools-scm 7.0.5 pyhd8ed1ab_0
    - pluggy 1.0.0 py37h89c1867_3
    - hatchling 1.25.0 pyhd8ed1ab_0
    - hatch-vcs 0.3.0 pyhd8ed1ab_0

@conda-forge/hatchling I'm going to submit a patch to https://github.com/conda-forge/conda-forge-repodata-patches-feedstock that tries to patch the metadata from hatchling v1.18.0 to v1.25.0 (given the docs: https://conda-forge.org/docs/maintainer/guidelines/#fixing-broken-packages).

This has also been noted (in a different way) on conda-forge/hatchling-feedstock#47.

@matthewfeickert
Copy link
Member Author

@conda-forge-admin, please rerender

@matthewfeickert matthewfeickert force-pushed the mnt/use-noarch-variables branch from 91b7fa6 to 68db272 Compare November 11, 2024 23:19
@matthewfeickert
Copy link
Member Author

@conda-forge-admin, please rerender

@matthewfeickert matthewfeickert marked this pull request as ready for review November 11, 2024 23:27
@matthewfeickert matthewfeickert merged commit a10b681 into conda-forge:main Nov 11, 2024
4 checks passed
@matthewfeickert matthewfeickert deleted the mnt/use-noarch-variables branch November 11, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants