-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin Java version + add support for Java 9, 10, 11 #5
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@jakirkham & @sodre: does this approach make sense to you? |
@hadim, if you are trying to build
|
I just saw your conda_build_config.yaml and meta.yaml files. I think you just need to add the max_pin to conda_build_config.yaml, remove the build.string field, and rerun codna smithy rerender to get this to work. |
@hanslovsky : ready for review/merge. |
Good news: the next version of pyjnius will be compatible with Java >=9: kivy/pyjnius#363 |
This is a work in progress: DO NOT MERGE. |
But since it does not depend on a compiler, why it is not available on some of them? |
I think it is because it has not gone through the GCC7 Migration yet, e.g. the build number is <1000 |
Ok, so it's an easy fix I guess. Can I migrate myself? Or do I have to wait for the bot? |
I checked https://conda-forge.org/status/ and couldn't find As already said the compiler is only declared in the test section. Is that why a compiler is declared in the yaml configuration? A solution would be to remove tests that use C compiler, that would make the package compiler-independent. On the other side, I think it's a good practice to check that JNI compilation works. |
This PR should fix the issue conda-forge/openjdk-feedstock#42 Once it's merged I will remove the hard-coded C compilers from this PR. |
To do before merging here:
|
It's almost good. Only OSX builds for
It's weird because conda-forge has those builds. Example for Java 11: https://anaconda.org/conda-forge/openjdk/files?version=11.0.1. There is OSX builds for both {
"c_compiler": "toolchain_c"
} Does Anaconda repos have an index that could have been confused by the java branches I have created on the Java feedstock repo? See https://github.com/conda-forge/openjdk-feedstock/branches |
I guess conda servers have been fixed because the missing OSX OpenJDK packages are back. It's all green now. Now waiting for a pyjnius release. |
@sodre could you review, please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hadim this looks fine to me minus the build_number jinja2 expression and the fact that we are still pulling from github.
Keep in mind that I am not a maintainer of this package so I can't really merge this into the master branch.
@sodre Is that ok to release a Something like |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
That is probably a question better asked to @conda-forge/core ... |
I got a green light on gitter from @CJ-Wright to merge here. @hanslovsky only can merge this PR and I know he is AFK for two weeks. @CJ-Wright: could you merge this PR (if you can...)? |
@hadim any interest in joining the maintainers of this package? |
I will be once this PR is merged :-) |
sorry I missed that bit |
@hanslovsky: Here is a first try to pin the Java version.