Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARM OSX Migrator #162

Merged
merged 5 commits into from
Dec 21, 2022
Merged

ARM OSX Migrator #162

merged 5 commits into from
Dec 21, 2022

Conversation

regro-cf-autotick-bot
Copy link
Contributor

@regro-cf-autotick-bot regro-cf-autotick-bot commented Dec 14, 2022 •
edited by hmaarrfk
Loading

Closes #165
Closes #160
This feedstock is being rebuilt as part of the ARM OSX migration.

Feel free to merge the PR if CI is all green, but please don't close it
without reaching out the the ARM OSX team first at @conda-forge/help-osx-arm64.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/3695471116, please use this URL for debugging.

@conda-forge-linter
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@hmaarrfk
Copy link
Contributor

@conda-forge-admin please rerender

1 similar comment
@hmaarrfk
Copy link
Contributor

@conda-forge-admin please rerender

@conda-forge-linter
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@hmaarrfk hmaarrfk force-pushed the bot-pr_arm_osx_hbc2590 branch from ad059e7 to f4e6947 Compare December 15, 2022 04:31
@conda-forge-linter
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@hmaarrfk hmaarrfk marked this pull request as draft December 15, 2022 05:15
@hmaarrfk
Copy link
Contributor

@h-vetinari well now we can converge to an environment, but they both have errors like:

$SRC_DIR/sources/shiboken6/ApiExtractor/clangparser/clangbuilder.cpp:308:10: error: use of undeclared identifier 'CXCursor_ExceptionSpecificationKind_NoThrow'; did you mean 'CXCursor_ExceptionSpecificationKind_None'?
    case CXCursor_ExceptionSpecificationKind_NoThrow:
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         CXCursor_ExceptionSpecificationKind_None

But i can see htat it is declared in the llvm sources, at least in 14 https://github.com/hdoc/llvm-project/blob/release/14.x/clang/include/clang-c/Index.h#L223
which is really werid.

@h-vetinari
Copy link
Member

It might be that $SRC_DIR/sources/shiboken6/ApiExtractor/clangparser/clangbuilder.cpp is bound to (or only compatible with) specific LLVM versions...

@hmaarrfk
Copy link
Contributor

I think it is maybe finding the system Index.h file...

@hmaarrfk
Copy link
Contributor

nevermind, clangdev was set to 5.x for some reason.

h-vetinari
h-vetinari reviewed Dec 20, 2022
View reviewed changes
recipe/meta.yaml Outdated Show resolved Hide resolved
@hmaarrfk
Copy link
Contributor

@conda-forge-admin please rerender

hmaarrfk and others added 2 commits December 20, 2022 07:43
@hmaarrfk
Pin libclang and clangdev to match build compilers
df2722f
@hmaarrfk @h-vetinari
better pins
fb71434 
Co-authored-by: h-vetinari <h.vetinari@gmx.com>
@hmaarrfk hmaarrfk force-pushed the bot-pr_arm_osx_hbc2590 branch from becda78 to c676f19 Compare December 20, 2022 12:43
@hmaarrfk hmaarrfk added the automerge Merge the PR when CI passes label Dec 20, 2022
@hmaarrfk hmaarrfk marked this pull request as ready for review December 20, 2022 12:46
@hmaarrfk hmaarrfk added automerge Merge the PR when CI passes and removed automerge Merge the PR when CI passes labels Dec 20, 2022
@hmaarrfk
Copy link
Contributor

Thanks! excited to get this through

@github-actions
Copy link
Contributor

github-actions bot commented Dec 20, 2022 •
edited
Loading

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@hmaarrfk
Copy link
Contributor 

-   - package gstreamer-1.21.2-hcb7b3dd_0 requires python_abi 3.10.* *_cp310, but none of the providers can be installed

hmm.

h-vetinari
h-vetinari reviewed Dec 20, 2022
View reviewed changes
recipe/meta.yaml Outdated Show resolved Hide resolved
@h-vetinari
Copy link
Member 

-   - package gstreamer-1.21.2-hcb7b3dd_0 requires python_abi 3.10.* *_cp310, but none of the providers can be installed

hmm.

We should get rid of the spurious python run-export that's introduced by this.

@hmaarrfk
Copy link
Contributor

But just above it, it has the ignore_run_export https://github.com/conda-forge/gstreamer-feedstock/blob/main/recipe/meta.yaml#L31

@github-actions github-actions bot removed the automerge Merge the PR when CI passes label Dec 21, 2022
@github-actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@hmaarrfk
Copy link
Contributor

I think we are hitting:
conda/conda-build#3973

and
https://github.com/conda-forge/cross-python-feedstock/blob/c356bb3a8fc9d98bf6fa8ae6c4fe3ca8e33ec9d6/recipe/meta.yaml#L18

@hmaarrfk
Copy link
Contributor

I'm trying to fix it through: conda-forge/gstreamer-feedstock#85

@conda-forge-linter
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Old-style Python selectors (py27, py35, etc) are only available for Python 2.7, 3.4, 3.5, and 3.6. Please use explicit comparisons with the integer py, e.g. # [py==37] or # [py>=37]. See lines [27, 28]

@hmaarrfk
Copy link
Contributor

@conda-forge-admin please rerender

hmaarrfk
hmaarrfk reviewed Dec 21, 2022
View reviewed changes
recipe/meta.yaml Outdated Show resolved Hide resolved
@conda-forge-linter
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@hmaarrfk
Copy link
Contributor

@conda-forge-admin please rerender

@hmaarrfk
Copy link
Contributor

Needs: conda-forge/gstreamer-feedstock#87

hmaarrfk
hmaarrfk reviewed Dec 21, 2022
View reviewed changes
recipe/meta.yaml Outdated Show resolved Hide resolved
@hmaarrfk
Copy link
Contributor

@conda-forge-admin please rerender

@hmaarrfk hmaarrfk added the automerge Merge the PR when CI passes label Dec 21, 2022
@hmaarrfk hmaarrfk force-pushed the bot-pr_arm_osx_hbc2590 branch from 54253f0 to 6054fbb Compare December 21, 2022 04:40
@github-actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@github-actions github-actions bot removed the automerge Merge the PR when CI passes label Dec 21, 2022
@hmaarrfk hmaarrfk added the automerge Merge the PR when CI passes label Dec 21, 2022
@github-actions github-actions bot merged commit 0244fff into conda-forge:pyside6 Dec 21, 2022
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the bot-pr_arm_osx_hbc2590 branch December 21, 2022 06:37
@h-vetinari h-vetinari mentioned this pull request Dec 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-vetinari h-vetinari h-vetinari left review comments

@hmaarrfk hmaarrfk hmaarrfk left review comments

@jan-janssen jan-janssen Awaiting requested review from jan-janssen jan-janssen is a code owner

@jschueller jschueller Awaiting requested review from jschueller jschueller is a code owner

Assignees
No one assigned
Labels
automerge Merge the PR when CI passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@regro-cf-autotick-bot @conda-forge-linter @hmaarrfk @h-vetinari