Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply Python 3.11 migration #152

Merged
merged 2 commits into from
Oct 26, 2022
Merged

Apply Python 3.11 migration #152

merged 2 commits into from
Oct 26, 2022

Conversation

chrisburr
Copy link
Member

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@chrisburr
Copy link
Member Author

Cross-compilation needs conda-forge/cross-python-feedstock#56

@nicoddemus
Copy link
Member

Thanks @chrisburr!

I see conda-forge/cross-python-feedstock#56 was merged, do we need to trigger something here now?

@chrisburr
Copy link
Member Author

Looks like there are some cross-compilation issues to work out for Python 3.11, I'll look into it.

@chrisburr
Copy link
Member Author

@conda-forge/pytest This should be ready to go (feel free to merge the bot's PR instead if you'd prefer, I just used this package for testing the migrator manually).

@h-vetinari
Copy link
Member

h-vetinari commented Oct 26, 2022

It would be good to merge this as soon as feasible because a lot of feedstocks in the migration depend on this, but the migrator doesn't take that into account. This is because unfortunately the dependency graph for the migrator is built without test-only dependencies (which pytest almost always is), as that can lead to circularities (e.g. package A depending on B, and package B using A as a test-only dependency; this is not a build-level circularity, "just" on on recipe-level one).

@chrisburr chrisburr merged commit a268677 into conda-forge:main Oct 26, 2022
@chrisburr chrisburr deleted the 3.11 branch October 26, 2022 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants