Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for icu72 #136

Conversation

regro-cf-autotick-bot
Copy link
Contributor

@regro-cf-autotick-bot regro-cf-autotick-bot commented Mar 28, 2023

This PR has been triggered in an effort to update icu72.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/4539216472, please use this URL for debugging.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@hmaarrfk
Copy link
Contributor

Is anybody able to compile ppc64le successfully? I'm getting these errors:

/home/conda/feedstock_root/build_artifacts/qt-main_1680100070347/work/qt-build/qtbase/bin/qmake: error while loading shared libraries: libstdc++.so.6: cannot open shared object file: No such file or directory

ppc64le.log.txt

There may be a missing CDT or something?

@hmaarrfk
Copy link
Contributor

cc: @matthiasdiener

conda-forge.yml Outdated Show resolved Hide resolved
@hmaarrfk hmaarrfk force-pushed the rebuild-icu72-0-1_hde268e branch from fbf8f40 to c343af6 Compare March 29, 2023 17:22
@Tobias-Fischer
Copy link
Contributor

Seems like the osx-64 error is this one:

2023-03-29T20:03:21.6982060Z /Users/runner/miniforge3/conda-bld/qt-main_1680110907138/work/qtmultimedia/src/plugins/avfoundation/camera/avfcamerautility.mm:104:35: error: no template named 'unary_function' in namespace 'std'; did you mean '__unary_function'?
2023-03-29T20:03:21.6986020Z struct FormatHasNoFPSRange : std::unary_function<AVCaptureDeviceFormat *, bool>
2023-03-29T20:03:21.6987100Z                              ~~~~~^~~~~~~~~~~~~~
2023-03-29T20:03:21.6987970Z                                   __unary_function
2023-03-29T20:03:21.6989060Z /Users/runner/miniforge3/conda-bld/qt-main_1680110907138/_build_env/bin/../include/c++/v1/__functional/unary_function.h:46:1: note: '__unary_function' declared here
2023-03-29T20:03:21.6989980Z using __unary_function = __unary_function_keep_layout_base<_Arg, _Result>;
2023-03-29T20:03:21.6990760Z ^
2023-03-29T20:03:22.0125370Z 1 error generated.
2023-03-29T20:03:22.0264060Z make[5]: *** [Makefile:7758: .obj/avfcamerautility.o] Error 1
2023-03-29T20:03:22.0266760Z make[5]: Leaving directory '$SRC_DIR/qt-build/qtmultimedia/src/plugins/avfoundation/camera'
2023-03-29T20:03:22.0273320Z make[4]: *** [Makefile:80: sub-camera-make_first] Error 2
2023-03-29T20:03:22.0274910Z make[4]: Leaving directory '$SRC_DIR/qt-build/qtmultimedia/src/plugins/avfoundation'
2023-03-29T20:03:22.0283770Z make[3]: *** [Makefile:184: sub-avfoundation-make_first] Error 2
2023-03-29T20:03:22.0285130Z make[3]: Leaving directory '$SRC_DIR/qt-build/qtmultimedia/src/plugins'
2023-03-29T20:03:22.0292750Z make[2]: *** [Makefile:189: sub-plugins-make_first] Error 2
2023-03-29T20:03:22.0293910Z make[2]: Leaving directory '$SRC_DIR/qt-build/qtmultimedia/src'
2023-03-29T20:03:22.0305240Z make[1]: *** [Makefile:56: sub-src-make_first] Error 2
2023-03-29T20:03:22.0306450Z make[1]: Leaving directory '$SRC_DIR/qt-build/qtmultimedia'
2023-03-29T20:03:22.0313930Z make: *** [Makefile:847: module-qtmultimedia-make_first] Error 2

Seems like there has been a change regarding this in clang-15, but we use clang-14 as far as I can see. On the other hand, we use libcxx 16 so maybe that's the culprit? The latest working build on main uses an older version:
libcxx: 16.0.0-h71dddab_0 conda-forge in this PR vs
libcxx: 15.0.7-h71dddab_0 conda-forge on main

@hmaarrfk
Copy link
Contributor

Sigh. Ok. Maybe roll back the osx changes.

I got PPC working by going back to native compilation

@Tobias-Fischer
Copy link
Contributor

What's the correct way of pinning libcxx?

@hmaarrfk
Copy link
Contributor

i'm not sure. i did upload the ppc64le build, so hopefully we can make changes that only affect osx to fix it.

@h-vetinari
Copy link
Member

h-vetinari commented Mar 30, 2023

The removal of the deprecated-in-C++17 std::unary_function has now finally been executed in libcxx 16, so this is expected breakage. Your choices are to add a run-constraint to libcxx<16, or use the magic symbol. For details see conda-forge/libcxx-feedstock#114

@hmaarrfk
Copy link
Contributor

Thank you for the explanation. Given that even the development branch of qt is still using the function, I'm tempted to use the flag while an issue upstream

https://github.com/qt/qtmultimedia/blob/a59dd941ab45f203587618e0f57522fa46802624/src/plugins/multimedia/darwin/camera/avfcamerautility.mm#L72

From https://stackoverflow.com/questions/63577103/what-is-an-equivalent-replacement-for-stdunary-function-in-c17

it seems that I could just "remove the std::unary_operator" right?

@h-vetinari
Copy link
Member

From https://stackoverflow.com/questions/63577103/what-is-an-equivalent-replacement-for-stdunary-function-in-c17

it seems that I could just "remove the std::unary_operator" right?

This matches my understanding (the SO answer is pretty thorough).

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Apr 1, 2023

I attempted to add the flag, but I'm going to work on a patch in the meantime. If things work with the flag, I'll likely choose that I've spent too much time on it and just use the flag.

@hmaarrfk hmaarrfk marked this pull request as draft April 1, 2023 16:42
@hmaarrfk
Copy link
Contributor

hmaarrfk commented Apr 1, 2023

See #138

@hmaarrfk hmaarrfk closed this in #138 Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants