Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.5.55-1: Pin pandoc more strictly and restore quarto-preview.js #59

Merged
merged 5 commits into from
Sep 9, 2024

Conversation

mfisher87
Copy link
Member

@mfisher87 mfisher87 commented Sep 8, 2024

Closes #58
Closes #53

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@mfisher87
Copy link
Member Author

@conda-forge-admin, please rerender

@mfisher87
Copy link
Member Author

mfisher87 commented Sep 8, 2024

Can we also fix the problem with quarto-preview.js not getting packaged as part of this release ( #53 )? I don't have any ideas yet why this stopped working. @cderv any idea on your end?

conda-forge-webservices[bot] and others added 2 commits September 8, 2024 02:39
@mfisher87 mfisher87 changed the title 1.5.55-1: Pin pandoc more strictly 1.5.55-1: Pin pandoc more strictly and restore quarto-preview.js Sep 8, 2024
@mfisher87
Copy link
Member Author

mfisher87 commented Sep 8, 2024

Restoring the patch we used to use to force it to be built fixed the problem (0532970). I thought this was no longer needed due to upstream changes, and I didn't test thoroughly enough it seems.

@mfisher87 mfisher87 mentioned this pull request Sep 8, 2024
3 tasks
@mfisher87
Copy link
Member Author

This did not result in the pin I expected. The repodata shows:

    "pandoc 3.2.*",
    "typst 0.11.0.*"

@mfisher87
Copy link
Member Author

Latest commit fixes it:

    "pandoc 3.2",
    "typst 0.11.0"

@cderv
Copy link

cderv commented Sep 9, 2024

This is really awesome ! Thank you !

Restoring the patch we used to use to force it to be built fixed the problem (0532970). I thought this was no longer needed due to upstream changes, and I didn't test thoroughly enough it seems.

Oh so this was it. I thought also this was handled now. 🤔
I'll try to understand why it did not happened as expected.

@mfisher87 mfisher87 merged commit 0d1b72a into conda-forge:main Sep 9, 2024
6 checks passed
@mfisher87
Copy link
Member Author

Oh so this was it. I thought also this was handled now. 🤔
I'll try to understand why it did not happened as expected.

Thanks, Christophe! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants