-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run_constrained: chardet #54
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2022.06.25.09.06.17
@ocefpaf I think
I get
which are incompatible with each other. I'll submit a PR to https://github.com/conda-forge/admin-requests. |
Thanks @teake. We can also try a repo data patch but b/c we have this build number 1 here it is probably not worth it. Marking as broken is fine. |
Upgrading to the new build is a bit tricky, one needs to explicitly provide the build number, otherwise chardet won't be downgraded (downgrading is penalized more than increasing build number). This should work (if anyone else has this issue), see #55
|
Thanks everyone, but is this severe enough? I only submitted this fix as an abundance of caution going forward and I was not too worried about past builds. Upstream only emits a warning about the inconsistent deps, but not a full-blown error. Also note, |
@ngam a repodata patch would have avoided this but, in a way, this is a "bug" in conda. Existing envs don't know if a package was pulled and they won't update to a higher build number. |
Ah. I now see how things got confused... Oh well... |
With 2.28.0-0 marked as broken, I now get:
This combination also emits the incompatibility warning. Sigh. If we want to avoid combinations that emit this warning, I guess all previous requests builds of 2.26 and 2.27 should be patched (the upstream commit was first included in 2.26.0). If somebody wants to pick this up, that'd be great -- the instructions in https://github.com/conda-forge/conda-forge-repodata-patches-feedstock/tree/main/recipe are not at all clear to me. Btw, upstream has just upped the optional dependency to chardet<6: psf/requests#6179. |
@ocefpaf or I can do this soon. Also, opening #56 as this also appears in CI now. Let's continue the discussion there |
See for a thorough update: conda-forge/conda-forge-repodata-patches-feedstock#287 including reverting marking the previous build as broken |
fixes #53
(I am not sure this is the best solution or the desirable solution here, so reviewers should carefully assess)
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)