Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sphinx-autosummary-accessors #12343

Merged
merged 4 commits into from
Aug 10, 2020

Conversation

keewis
Copy link
Contributor

@keewis keewis commented Aug 9, 2020

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml"
  • License file is packaged (see here for an example)
  • Source is from official source
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged)
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details)
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/sphinx-autosummary-accessors) and found it was in an excellent condition.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/sphinx-autosummary-accessors) and found some lint.

Here's what I've got...

For recipes/sphinx-autosummary-accessors:

  • requirements: host: python >= 3.6 should not contain a space between relational operator and the version, i.e. python >=3.6
  • requirements: run: python >= 3.6 should not contain a space between relational operator and the version, i.e. python >=3.6

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/sphinx-autosummary-accessors) and found it was in an excellent condition.

imports:
- sphinx_autosummary_accessors
commands:
- pip check
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error on windows is due to pip check, although it looks to maybe be spurious since colorama is only required for win32 (https://github.com/sphinx-doc/sphinx/blob/eddfa686bef5955335576cb2b1c91931ac825cb9/setup.py#L38-L40), and I think we're building on win64. I think since this is noarch: python, we can ignore this error since the recipe will only be built on linux anyways.

@conda-forge/staged-recipes -- Any thoughts on this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is noarch so we can ignore

@scopatz scopatz merged commit 21cb59c into conda-forge:master Aug 10, 2020
@keewis keewis deleted the sphinx-autosummary-accessors branch August 10, 2020 01:23
@keewis
Copy link
Contributor Author

keewis commented Aug 10, 2020

thanks, @synapticarbors and @scopatz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants