-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add sphinx-autosummary-accessors #12343
add sphinx-autosummary-accessors #12343
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/sphinx-autosummary-accessors:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
imports: | ||
- sphinx_autosummary_accessors | ||
commands: | ||
- pip check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error on windows is due to pip check
, although it looks to maybe be spurious since colorama
is only required for win32 (https://github.com/sphinx-doc/sphinx/blob/eddfa686bef5955335576cb2b1c91931ac825cb9/setup.py#L38-L40), and I think we're building on win64. I think since this is noarch: python
, we can ignore this error since the recipe will only be built on linux anyways.
@conda-forge/staged-recipes -- Any thoughts on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this is noarch so we can ignore
thanks, @synapticarbors and @scopatz |
Checklist
If static libraries are linked in, the license of the static library is packaged.url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details)