Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dice-ml #19442

Merged
merged 2 commits into from
Jun 28, 2022
Merged

add dice-ml #19442

merged 2 commits into from
Jun 28, 2022

Conversation

bgalvao
Copy link
Contributor

@bgalvao bgalvao commented Jun 27, 2022

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/dice-ml) and found it was in an excellent condition.

@bgalvao
Copy link
Contributor Author

bgalvao commented Jun 27, 2022

@janjagusch I think this noarch is good to go

@bgalvao bgalvao mentioned this pull request Jun 27, 2022
9 tasks
Copy link
Contributor

@janjagusch janjagusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! @xhochy, could you give this a final review, please?

We will add the license file to the sdist in an upstream PR and adjust the feedstock afterward.

@dopplershift dopplershift merged commit a91aa1e into conda-forge:main Jun 28, 2022
@bgalvao bgalvao mentioned this pull request Jul 24, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants