Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added juliacall as a package #20379

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added juliacall as a package #20379

wants to merge 1 commit into from

Conversation

thewchan
Copy link
Contributor

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/juliacall) and found it was in an excellent condition.

@thewchan
Copy link
Contributor Author

Awaiting #20380

@thewchan thewchan mentioned this pull request Sep 10, 2022
Closed
10 tasks
ngam
ngam suggested changes Sep 10, 2022
View reviewed changes
Copy link
Contributor

@ngam ngam left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hold this a bit longer. We need:

  • agree on naming (julia-pythoncall likely)
  • follow strategy outline elsewhere to ensure optimal support (e.g. julia-pythoncall establishing a depot for PythonCall.jl and so on)

@thewchan
Copy link
Contributor Author

Understood, let me know if you need anything from me.

This was referenced Sep 10, 2022
Merged
Closed
@mkitti
Copy link
Contributor

mkitti commented Sep 11, 2022

@ngam, actually I think the more likely name for this is python-juliacall or pyjuliacall. I prefer "python-juliacall" to distinguish it from "pyjulia" which serves a similar function.

The corresponding pip package for this is:
https://pypi.org/project/juliacall/

@mkitti
Copy link
Contributor

mkitti commented Sep 11, 2022

cc: @cjdoris

@cjdoris cjdoris mentioned this pull request Sep 11, 2022
Open
@cjdoris
Copy link

cjdoris commented Sep 11, 2022

See #20380 (comment).

@mkitti
Copy link
Contributor

mkitti commented Sep 20, 2022

@cjdoris what needs to be done in order for PythonCall to use the current conda environment. See the discussion in
https://discourse.julialang.org/t/how-to-use-pythoncall-with-a-previous-conda-environment/87419/8?u=mkitti

How does that affect juliacall?

@mkitti
Copy link
Contributor

mkitti commented Sep 20, 2022

My best understanding is that https://github.com/cjdoris/PythonCall.jl/blob/1eee57318a315feea55458d1d6cb5a6e67b1f44f/pysrc/juliacall/__init__.py#L203 means that PythonCall will use the current python executable and thus use the current conda environment.

@cjdoris
Copy link

cjdoris commented Sep 20, 2022

You just set JULIA_PYTHONCALL_EXE=/path/to/python. If you are using JuliaCall, then as observed this is automatically set to the Python executable being used. So if you are using Python from a Conda env, then the embedded PythonCall will have access to all the packages in that same env.

I'd recommend setting JULIA_PYTHONCALL_EXE explicitly if possible (e.g. in the conda-forge activate script for Julia) because it is possible for sys.executable to not actually be a Python executable (e.g. if Python is embedded into a different executable).

mkitti
mkitti suggested changes Sep 21, 2022
View reviewed changes
Copy link
Contributor

@mkitti mkitti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change name to pyjuliacall

recipes/juliacall/meta.yaml
@@ -0,0 +1,43 @@
{% set name = "juliacall" %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{% set name = "juliacall" %}
{% set name = "pyjuliacall" %}

recipes/juliacall/meta.yaml
- setuptools >=42
run:
- python >=3.7
- juliapkg >=0.1.8,<0.2.dev0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- juliapkg >=0.1.8,<0.2.dev0
- pyjuliapkg >=0.1.8,<0.2.dev0

recipes/juliacall/meta.yaml

test:
imports:
- juliacall
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- juliacall
- pyjuliacall

@stale
Copy link

stale bot commented Mar 29, 2023

Hi friend!

We really, really, really appreciate that you have taken the time to make a PR on conda-forge/staged-recipes! conda-forge only exists because people like you donate their time to build and maintain conda recipes for use by the community.

In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of staged-recipes close excessively old PRs after six months. This PR will remain open for another month, and then will be closed.

If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on main so that they can be rebuilt with the most recent CI scripts. If you have any trouble, or we missed reviewing this PR in the first place (sorry!), feel free to ping the team using a special command in a comment on the PR to get the attention of the staged-recipes team.

Cheers and thank you for contributing to this community effort!

@stale stale bot added the stale will be closed in 30 days label Mar 29, 2023
@mkitti
Copy link
Contributor

mkitti commented Mar 29, 2023

We should figure out how to move forward here.

@stale stale bot removed the stale will be closed in 30 days label Mar 29, 2023
@mkitti mkitti mentioned this pull request May 9, 2023
Open
@cjdoris cjdoris mentioned this pull request Oct 10, 2023
Closed
@MilesCranmer
Copy link
Contributor

MilesCranmer commented Dec 29, 2023 •
edited
Loading

Pinging this. Does this still depend on #20379? Or are they separate?

Edit: meant #20380

@mkitti
Copy link
Contributor

mkitti commented Dec 29, 2023

This is 20379.

@MilesCranmer
Copy link
Contributor

Sorry, I meant #20380

@mkitti
Copy link
Contributor

mkitti commented Dec 29, 2023

To clarify my position, these should be resubmitted as pyjuliapkg and pyjuliacall.

@MilesCranmer
Copy link
Contributor

Cool. Is that the only thing left or were there other issues?

@MilesCranmer
Copy link
Contributor

Pinging this thread again ^ Is that the only change needed?

This was referenced Jan 22, 2024
Merged
Draft
@MilesCranmer
Copy link
Contributor

Can close in favor of #25097

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngam ngam ngam requested changes

@mkitti mkitti mkitti requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@thewchan @conda-forge-linter @mkitti @cjdoris @MilesCranmer @ngam