Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding cuda-cuobjdump, cuda-cuxxfilt, and cuda-nvprune recipes #21878

Merged
merged 13 commits into from
Jun 2, 2023

Conversation

adibbley
Copy link
Contributor

@adibbley adibbley commented Jan 26, 2023

Adding cuda-cuobjdump, cuda-cuxxfilt, and cuda-nvprune recipes

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/cuda-cccl, recipes/cuda-cuobjdump, recipes/cuda-cuxxfilt, recipes/cuda-nvprune, recipes/cuda-nvrtc) and found some lint.

Here's what I've got...

For recipes/cuda-cuobjdump:

  • The top level meta keys are in an unexpected order. Expecting ['package', 'source', 'build', 'requirements', 'test', 'about', 'extra'].

For recipes/cuda-cuxxfilt:

  • The top level meta keys are in an unexpected order. Expecting ['package', 'source', 'build', 'requirements', 'test', 'about', 'extra'].

For recipes/cuda-nvprune:

  • The top level meta keys are in an unexpected order. Expecting ['package', 'source', 'build', 'requirements', 'test', 'about', 'extra'].

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/cuda-cccl, recipes/cuda-cuobjdump, recipes/cuda-cuxxfilt, recipes/cuda-nvprune, recipes/cuda-nvrtc) and found it was in an excellent condition.

@adibbley adibbley marked this pull request as ready for review January 26, 2023 21:01
@adibbley
Copy link
Contributor Author

cc @jakirkham

@adibbley adibbley mentioned this pull request Jan 26, 2023
49 tasks
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/cuda-cccl, recipes/cuda-cuobjdump, recipes/cuda-cuxxfilt, recipes/cuda-nvprune) and found it was in an excellent condition.

@adibbley adibbley changed the title Adding cuda-cccl, cuda-cuobjdump, cuda-cuxxfilt, cuda-nvprune, and cu… Adding cuda-cccl, cuda-cuobjdump, cuda-cuxxfilt, and cuda-nvprune recipes Feb 3, 2023
@adibbley adibbley marked this pull request as draft February 3, 2023 21:04
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/cuda-cuobjdump, recipes/cuda-cuxxfilt, recipes/cuda-nvprune) and found it was in an excellent condition.

@adibbley adibbley changed the title Adding cuda-cccl, cuda-cuobjdump, cuda-cuxxfilt, and cuda-nvprune recipes Adding cuda-cuobjdump, cuda-cuxxfilt, and cuda-nvprune recipes Feb 3, 2023
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested cuda-version pinnings.

recipes/cuda-cuobjdump/meta.yaml Show resolved Hide resolved
recipes/cuda-cuxxfilt/meta.yaml Show resolved Hide resolved
recipes/cuda-nvprune/meta.yaml Show resolved Hide resolved
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
recipes/cuda-cuobjdump/meta.yaml Show resolved Hide resolved
recipes/cuda-cuobjdump/meta.yaml Outdated Show resolved Hide resolved
recipes/cuda-cuxxfilt/meta.yaml Show resolved Hide resolved
recipes/cuda-cuxxfilt/meta.yaml Outdated Show resolved Hide resolved
recipes/cuda-nvprune/meta.yaml Show resolved Hide resolved
recipes/cuda-nvprune/meta.yaml Outdated Show resolved Hide resolved
@adibbley adibbley marked this pull request as ready for review April 25, 2023 18:02
@jakirkham jakirkham merged commit 6e26940 into conda-forge:main Jun 2, 2023
@jakirkham
Copy link
Member

Thanks all! 🙏

Let's get this into feedstocks. We can follow up on anything else there 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants