-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cuda-cupti recipe #22355
Add cuda-cupti recipe #22355
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/cuda-cupti:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
cc @bdice |
Thanks Bradley! 🙏 These are good suggestions. For |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jakirkham Good call on using pin_compatible
. I reviewed this recipe before looking back at cublas, so I forgot that. It's fixed now and I deleted the outdated suggestions.
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/cuda-cupti:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Co-authored-by: Robert Maynard <robertjmaynard@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor requests. Recipe looks fine aside from those. I haven't checked the package contents yet.
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Saw a test failure on CI. Proposed a (potential) fix below. Though please double check
Co-authored-by: jakirkham <jakirkham@gmail.com>
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
Thanks all! 🙏 Let's follow up on anything else in the feedstock 🙂 |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).