Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cuda-cupti recipe #22355

Merged
merged 23 commits into from
Apr 18, 2023
Merged

Add cuda-cupti recipe #22355

merged 23 commits into from
Apr 18, 2023

Conversation

adibbley
Copy link
Contributor

@adibbley adibbley commented Mar 21, 2023

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/cuda-cupti) and found some lint.

Here's what I've got...

For recipes/cuda-cupti:

  • The recipe must have some tests.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/cuda-cupti) and found it was in an excellent condition.

@adibbley adibbley mentioned this pull request Mar 21, 2023
49 tasks
@jakirkham
Copy link
Member

cc @bdice

recipes/cuda-cupti/meta.yaml Show resolved Hide resolved
recipes/cuda-cupti/meta.yaml Outdated Show resolved Hide resolved
@jakirkham
Copy link
Member

jakirkham commented Mar 22, 2023

Thanks Bradley! 🙏

These are good suggestions.

For cuda-version do we want to pin like this or use {{ pin_compatible("cuda-version", max_pin="x.x") }} as suggested in libcublas? Think whatever we decide to do regarding that question, it would be good to do consistently across CTK packages

Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jakirkham Good call on using pin_compatible. I reviewed this recipe before looking back at cublas, so I forgot that. It's fixed now and I deleted the outdated suggestions.

recipes/cuda-cupti/meta.yaml Outdated Show resolved Hide resolved
recipes/cuda-cupti/meta.yaml Outdated Show resolved Hide resolved
recipes/cuda-cupti/meta.yaml Outdated Show resolved Hide resolved
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/cuda-cupti) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/cuda-cupti:

  • Jinja2 variable references are suggested to take a {{<one space><variable name><one space>}} form. See lines [39].

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/cuda-cupti) and found it was in an excellent condition.

recipes/cuda-cupti/meta.yaml Outdated Show resolved Hide resolved
recipes/cuda-cupti/meta.yaml Outdated Show resolved Hide resolved
recipes/cuda-cupti/meta.yaml Outdated Show resolved Hide resolved
recipes/cuda-cupti/build.sh Outdated Show resolved Hide resolved
recipes/cuda-cupti/build.sh Outdated Show resolved Hide resolved
recipes/cuda-cupti/build.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor requests. Recipe looks fine aside from those. I haven't checked the package contents yet.

recipes/cuda-cupti/meta.yaml Show resolved Hide resolved
recipes/cuda-cupti/meta.yaml Show resolved Hide resolved
recipes/cuda-cupti/meta.yaml Outdated Show resolved Hide resolved
adibbley and others added 3 commits April 6, 2023 19:04
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw a test failure on CI. Proposed a (potential) fix below. Though please double check

recipes/cuda-cupti/meta.yaml Outdated Show resolved Hide resolved
@adibbley adibbley marked this pull request as ready for review April 14, 2023 19:16
recipes/cuda-cupti/meta.yaml Outdated Show resolved Hide resolved
@jakirkham jakirkham requested a review from kkraus14 April 15, 2023 00:23
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
@jakirkham jakirkham merged commit b42c4a4 into conda-forge:main Apr 18, 2023
@jakirkham
Copy link
Member

Thanks all! 🙏

Let's follow up on anything else in the feedstock 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants