Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding cuda-gdb recipe #22780

Merged
merged 8 commits into from
Jun 2, 2023
Merged

Adding cuda-gdb recipe #22780

merged 8 commits into from
Jun 2, 2023

Conversation

adibbley
Copy link
Contributor

@adibbley adibbley commented May 9, 2023 •
edited
Loading

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/cuda-gdb) and found it was in an excellent condition.

@adibbley adibbley mentioned this pull request May 9, 2023
Closed
49 tasks
@adibbley adibbley marked this pull request as ready for review May 17, 2023 18:47
bdice
bdice reviewed May 30, 2023
View reviewed changes
recipes/cuda-gdb/build.sh
Comment on lines +7 to +9
[[ $i == "build_env_setup.sh" ]] && continue
[[ $i == "conda_build.sh" ]] && continue
[[ $i == "metadata_conda_debug.yaml" ]] && continue
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these still relevant?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, due to the lazy copying we do in these scripts. Tested without and they are picked up:

‘build_env_setup.sh’ -> ‘$PREFIX/build_env_setup.sh’
‘conda_build.sh’ -> ‘$PREFIX/conda_build.sh’
‘metadata_conda_debug.yaml’ -> ‘$PREFIX/metadata_conda_debug.yaml’

bdice
bdice reviewed May 30, 2023
View reviewed changes
recipes/cuda-gdb/meta.yaml Outdated Show resolved Hide resolved
@jakirkham jakirkham requested a review from bdice June 2, 2023 07:38
bdice
bdice approved these changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me!

@jakirkham jakirkham merged commit c5ea056 into conda-forge:main Jun 2, 2023
@jakirkham
Copy link
Member

jakirkham commented Jun 2, 2023 •
edited
Loading

Thank you both! 🙏

Let's get this out and follow up on anything else in the feedstock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adibbley @jakirkham @bdice