Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cuda-opencl recipe #23002

Merged
merged 13 commits into from
Jun 13, 2023
Merged

Add cuda-opencl recipe #23002

merged 13 commits into from
Jun 13, 2023

Conversation

adibbley
Copy link
Contributor

@adibbley adibbley commented Jun 2, 2023

xref: #21382

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/cuda-opencl) and found some lint.

Here's what I've got...

For recipes/cuda-opencl:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [21, 22]

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/cuda-opencl) and found it was in an excellent condition.

@adibbley adibbley mentioned this pull request Jun 2, 2023
49 tasks
recipes/cuda-opencl/build.sh Outdated Show resolved Hide resolved
recipes/cuda-opencl/meta.yaml Show resolved Hide resolved
@adibbley adibbley marked this pull request as ready for review June 6, 2023 18:55
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Alex! 🙏

Think we might want these changes on Windows

recipes/cuda-opencl/meta.yaml Outdated Show resolved Hide resolved
recipes/cuda-opencl/bld.bat Show resolved Hide resolved
recipes/cuda-opencl/meta.yaml Outdated Show resolved Hide resolved
recipes/cuda-opencl/meta.yaml Outdated Show resolved Hide resolved
Co-authored-by: jakirkham <jakirkham@gmail.com>
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/cuda-opencl) and found some lint.

Here's what I've got...

For recipes/cuda-opencl:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

Co-authored-by: jakirkham <jakirkham@gmail.com>
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/cuda-opencl) and found it was in an excellent condition.

Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Alex! 🙏

Found a small typo. FWIW here is the path specified by ocl-icd

recipes/cuda-opencl/build.sh Outdated Show resolved Hide resolved
recipes/cuda-opencl/meta.yaml Outdated Show resolved Hide resolved
recipes/cuda-opencl/meta.yaml Outdated Show resolved Hide resolved
Co-authored-by: jakirkham <jakirkham@gmail.com>
recipes/cuda-opencl/meta.yaml Outdated Show resolved Hide resolved
recipes/cuda-opencl/meta.yaml Outdated Show resolved Hide resolved
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
Co-authored-by: jakirkham <jakirkham@gmail.com>
@jakirkham jakirkham merged commit ef15750 into conda-forge:main Jun 13, 2023
@jakirkham
Copy link
Member

Thanks all! 🙏

Let's get this in. We can follow up on anything else in the feedstock 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants