Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add langchainplus-sdk #23151

Closed
wants to merge 9 commits into from
Closed

Conversation

vowelparrot
Copy link

@vowelparrot vowelparrot commented Jun 22, 2023

Add recipe for the langchainplus-sdk, generated using grayskull. This contains schemas used in some of the tracers in langchain

@conda-forge/help-python

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/langchainplus-sdk) and found some lint.

Here's what I've got...

For recipes/langchainplus-sdk:

  • The home item is expected in the about section.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/langchainplus-sdk) and found it was in an excellent condition.

Co-authored-by: Uwe L. Korn <xhochy@users.noreply.github.com>
@xhochy
Copy link
Member

xhochy commented Jul 5, 2023

You will need to list the langchain entry point in build: entry_points: ...

@dbast dbast mentioned this pull request Aug 3, 2023
10 tasks
@dbast
Copy link
Member

dbast commented Aug 3, 2023

@vowelparrot took the initiative and added the entry_point with test command.

@dbast
Copy link
Member

dbast commented Aug 3, 2023

@vowelparrot Can we pump the PR to version 0.0.17. That is the version which is required by langchain ==0.0.220, which is a requirement for jupyter-ai in #23554

I would also volunteer as maintainer, if this is of help here.

@vowelparrot
Copy link
Author

Sure thing. FYI we changed the package name from langchainplus-sdk to langsmith (https://pypi.org/project/langsmith/) which is what is being used in current versions of langchain, and that's already been added to conda, so if/when jupyter-ai updates it's langchain pinned version, this would come for free and would be more up-to-date

@vowelparrot
Copy link
Author

I'll hand off to @hinthornw to clean up

@dbast
Copy link
Member

dbast commented Aug 4, 2023

ok. right. they already have an issue open to upgrade to newer langchain versions jupyterlab/jupyter-ai#285 ... that would remove the need to add langchainplus-sdk at all.... I'll wait a bit and see how that goes. thanks!

@hinthornw
Copy link
Contributor

Even better :) Thank you for your patience!

Copy link

stale bot commented Jan 1, 2024

Hi friend!

We really, really, really appreciate that you have taken the time to make a PR on conda-forge/staged-recipes! conda-forge only exists because people like you donate their time to build and maintain conda recipes for use by the community.

In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of staged-recipes close excessively old PRs after six months. This PR will remain open for another month, and then will be closed.

If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on main so that they can be rebuilt with the most recent CI scripts. If you have any trouble, or we missed reviewing this PR in the first place (sorry!), feel free to ping the team using a special command in a comment on the PR to get the attention of the staged-recipes team.

Cheers and thank you for contributing to this community effort!

@stale stale bot added the stale will be closed in 30 days label Jan 1, 2024
Copy link

stale bot commented Feb 10, 2024

Hi again! About a month ago, we commented on this PR saying it would be closed in another month if it was still inactive. It has been a month and so now it is being closed. Thank you so much for making it in the first place and contributing to the community project that is conda-forge. If you'd like to reopen this PR, please feel free to do so at any time!

Cheers and have a great day!

@stale stale bot closed this Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale will be closed in 30 days
Development

Successfully merging this pull request may close these issues.

4 participants