-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cuda metapackage recipes #23178
Add cuda metapackage recipes #23178
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some questions like "why does cuda-nvml-dev
not belong to cuda-libraries-dev
?" and similarly for gds-tools
not being a part of cuda-command-line-tools
but I would guess that those questions are beyond the scope of conda-forge and are just part of the broader CUDA deployment decisions. This looks generally fine.
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think everything looks good here, just need to apply the maintainers list suggestion. Are there other action items needed before merging?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM assuming that we apply the suggestion to the maintainers list.
One thing that might be helpful for future readers of the recipe is to note that for versions we use {{ version }}
for metapackages and explicit version numbers for everything else. It's sort of hinted at by the current contents of the README, but it may be helpful to be more explicit.
Co-authored-by: jakirkham <jakirkham@gmail.com>
Thanks all! 🙏 Let's follow up on anything else on the feedstock |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).xref: #21382