Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add APtools #24761

Merged
merged 5 commits into from
Dec 17, 2023
Merged

Add APtools #24761

merged 5 commits into from
Dec 17, 2023

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Dec 12, 2023

A collection of tools for accelerator physics.

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

A collection of tools for accelerator physics.
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/aptools) and found it was in an excellent condition.

@ax3l
Copy link
Member Author

ax3l commented Dec 12, 2023

Needed for #24760

@ax3l
Copy link
Member Author

ax3l commented Dec 12, 2023

@conda-forge/help-python ready for review :)

@AngelFP
Copy link
Contributor

AngelFP commented Dec 12, 2023

I agree to be listed in this packages as a co-maintainer.

recipes/aptools/meta.yaml Outdated Show resolved Hide resolved
recipes/aptools/meta.yaml Outdated Show resolved Hide resolved
@ax3l ax3l mentioned this pull request Dec 13, 2023
10 tasks
ax3l and others added 2 commits December 12, 2023 18:30
Co-authored-by: Filipe <ocefpaf@gmail.com>
Copy link
Member

@dhirschfeld dhirschfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, I'm unable to merge myself, but FWIW :shipit:

@ax3l
Copy link
Member Author

ax3l commented Dec 14, 2023

@conda-forge/help-python ready for merge :)

recipes/aptools/meta.yaml Show resolved Hide resolved
Co-authored-by: Uwe L. Korn <xhochy@users.noreply.github.com>
@ax3l
Copy link
Member Author

ax3l commented Dec 15, 2023

@xhochy thanks for the test hint. I do not understand why it fails with

+ pip check
aptools 0.2.4 requires openpmd-api, which is not installed.

because openpmd-api is installed as part of the run section.

Note that openPMD-api is not installed with pip but simply placed correctly in a CMake install in the Python site-packages directories of conda.

@ax3l ax3l requested review from ocefpaf and xhochy December 15, 2023 21:06
recipes/aptools/meta.yaml Outdated Show resolved Hide resolved
@dhirschfeld
Copy link
Member

I do not understand why it fails

pip check is a tool designed for the pip ecosystem and as such, IME, it doesn't always work with conda packages. When it does, it's nice to have as it adds an extra layer of protection against publishing broken packages, but when it doesn't I just skip it.

There is a feature request for pip to allow ignoring certain packages so we can still get the benefits for the rest:

@xhochy xhochy merged commit 1a13cca into conda-forge:main Dec 17, 2023
5 checks passed
@ax3l ax3l deleted the add-aptools branch December 17, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants