Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for sqlalchemy-risingwave #25146

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

gforsyth
Copy link
Contributor

@gforsyth gforsyth commented Jan 26, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/sqlalchemy-risingwave) and found some lint.

Here's what I've got...

For recipes/sqlalchemy-risingwave:

  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/sqlalchemy-risingwave) and found some lint.

Here's what I've got...

For recipes/sqlalchemy-risingwave:

  • Recipe maintainer "KeiXiangWang" does not exist
  • The following maintainers have not yet confirmed that they are willing to be listed here: KeiXiangWang. Please ask them to comment on this PR if they are.
  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

@gforsyth gforsyth force-pushed the sqlalchemy-risingwave branch from 051b3aa to 0edf3ed Compare January 26, 2024 17:27
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/sqlalchemy-risingwave) and found some lint.

Here's what I've got...

For recipes/sqlalchemy-risingwave:

  • The following maintainers have not yet confirmed that they are willing to be listed here: KeXiangWang. Please ask them to comment on this PR if they are.

@KeXiangWang
Copy link

Confirm.

@gforsyth
Copy link
Contributor Author

@conda-forge-admin, please lint

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/sqlalchemy-risingwave) and found it was in an excellent condition.

@gforsyth
Copy link
Contributor Author

Hey @conda-forge/help-python this is ready for review!

@gforsyth
Copy link
Contributor Author

Hey @conda-forge/help-python -- just a gentle ping. This recipe is ready to go in!

@ocefpaf ocefpaf merged commit 21fb7db into conda-forge:main Jan 29, 2024
5 checks passed
@gforsyth gforsyth deleted the sqlalchemy-risingwave branch January 29, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants