Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add openqdc #27094

Merged
merged 4 commits into from
Oct 13, 2024
Merged

Add openqdc #27094

merged 4 commits into from
Oct 13, 2024

Conversation

FNTwin
Copy link
Contributor

@FNTwin FNTwin commented Jul 24, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/openqdc/meta.yaml) and found some lint.

Here's what I've got...

For recipes/openqdc/meta.yaml:

  • The home item is expected in the about section.
  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [15]
  • noarch packages can't have skips with selectors. If the selectors are necessary, please remove noarch: python.

For recipes/openqdc/meta.yaml:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@conda-forge-webservices
Copy link

conda-forge-webservices bot commented Jul 24, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/openqdc/meta.yaml) and found it was in an excellent condition.

@FNTwin
Copy link
Contributor Author

FNTwin commented Jul 24, 2024

@conda-forge/help-python, ready for review

(Windows failing build was expected.)

@FNTwin
Copy link
Contributor Author

FNTwin commented Jul 31, 2024

Also I'll be the maintainer

@FNTwin
Copy link
Contributor Author

FNTwin commented Aug 16, 2024

@conda-forge/help-python, bumping up as ready for review.

(Windows failing build was expected.)

Copy link

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@xhochy xhochy merged commit f9fdeb0 into conda-forge:main Oct 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants